You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/03/18 00:40:26 UTC
Review Request 44997: Fixed how we detect C++11 compiler support.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44997/
-----------------------------------------------------------
Review request for mesos and Joris Van Remoortere.
Bugs: MESOS-4963
https://issues.apache.org/jira/browse/MESOS-4963
Repository: mesos
Description
-------
Adopt a new version of the M4 macro from the upstream macro archive.
We no longer care about whether the compiler supports particular
C++11 features, so we can discard some previous local modifications
we had to this macro. This should also make it easier to mandate
C++14 support in the future.
Diffs
-----
configure.ac 8e4f03593df4a8ba13f00292963e351acc3f71c1
m4/ax_cxx_compile_stdcxx.m4 PRE-CREATION
m4/ax_cxx_compile_stdcxx_11.m4 6a859b89953df2132a75f61833d5d3316968ec99
Diff: https://reviews.apache.org/r/44997/diff/
Testing
-------
make check
Thanks,
Neil Conway
Re: Review Request 44997: Fixed how we detect C++11 compiler support.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44997/#review124132
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On March 17, 2016, 11:40 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44997/
> -----------------------------------------------------------
>
> (Updated March 17, 2016, 11:40 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-4963
> https://issues.apache.org/jira/browse/MESOS-4963
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adopt a new version of the M4 macro from the upstream macro archive.
> We no longer care about whether the compiler supports particular
> C++11 features, so we can discard some previous local modifications
> we had to this macro. This should also make it easier to mandate
> C++14 support in the future.
>
>
> Diffs
> -----
>
> configure.ac 8e4f03593df4a8ba13f00292963e351acc3f71c1
> m4/ax_cxx_compile_stdcxx.m4 PRE-CREATION
> m4/ax_cxx_compile_stdcxx_11.m4 6a859b89953df2132a75f61833d5d3316968ec99
>
> Diff: https://reviews.apache.org/r/44997/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>