[GitHub] [spark] HyukjinKwon commented on a diff in pull request #37616: [SPARK-40178][PYTHON][SQL] Fix partitioning hint parameters in PySpark

[GitBox <gi...@apache.org>]

HyukjinKwon commented on code in PR #37616:
URL: https://github.com/apache/spark/pull/37616#discussion_r952036075


##########
python/pyspark/sql/column.py:
##########
@@ -71,6 +71,18 @@ def _to_java_column(col: "ColumnOrName") -> JavaObject:
     return jcol
 
 
+def _to_java_expr(col: "ColumnOrName") -> JavaObject:
+    if isinstance(col, (Column, str)):

Review Comment:
   I am saying that there's a duplicate if-else here so the else branch here is unreachable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org