You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by technmsg <gi...@git.apache.org> on 2018/04/19 14:25:26 UTC
[GitHub] nifi pull request #2647: NIFI-5097 add client-side HTTP redirect to error in...
GitHub user technmsg opened a pull request:
https://github.com/apache/nifi/pull/2647
NIFI-5097 add client-side HTTP redirect to error index.jsp
Existing web error index page suggests user may have meant /nifi/ and crafts a contextPath link, may as well redirect them automatically. Non-human (i.e. curl/wget) can still retrieve the original source without being redirected.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [Y] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [Y] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [N] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [Y] Is your initial contribution a single, squashed commit?
### For code changes:
- [N] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [N] Have you written or updated unit tests to verify your changes?
- [N/A] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [N/A] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [N/A] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [N/A] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [N/A] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/technmsg/nifi patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2647.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2647
----
commit 3324f4fea3e4d2e9652e06edfeaf79662296b6db
Author: Alex Moundalexis <al...@...>
Date: 2018-04-19T14:17:23Z
add client-side HTTP redirect to error index.jsp
Existing web error index page suggests user may have meant /nifi/ and crafts a contextPath link, may as well redirect them automatically. Non-human (i.e. curl/wget) can still retrieve the original source without being redirected.
----
---
[GitHub] nifi pull request #2647: NIFI-5097 add client-side HTTP redirect to error in...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2647
---
[GitHub] nifi issue #2647: NIFI-5097 add client-side HTTP redirect to error index.jsp
Posted by technmsg <gi...@git.apache.org>.
Github user technmsg commented on the issue:
https://github.com/apache/nifi/pull/2647
Pretty such that the build was failing before this commit, FWIW.
---
[GitHub] nifi issue #2647: NIFI-5097 add client-side HTTP redirect to error index.jsp
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2647
i dont think there is any specific history for why we didn't. Asked gilman and he though it looked ok. I'll give it a try soon and if all good will merge. Travis tests unrelated to this are another matter that needs to be sorted. We had some trouble for a brief period with logs being too large causing travis failures to occur which then resulted in people ignoring travis...we'll fix.
---
[GitHub] nifi issue #2647: NIFI-5097 add client-side HTTP redirect to error index.jsp
Posted by jackowaya <gi...@git.apache.org>.
Github user jackowaya commented on the issue:
https://github.com/apache/nifi/pull/2647
Built locally for me with skip tests (tests failed in nifi-toolkit-encrypt-config which I believe to be unrelated). Worked as expected in browser (redirected) and curl (not redirected). I'm looking forward to learning if there was history behind not redirecting people.
---