You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2018/01/22 15:28:13 UTC

[kudu-CR] docs: fix number of number masters 

Attila Bukor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9091


Change subject: docs: fix number of number masters
......................................................................

docs: fix number of number masters

Added warnings to installation and administration about having an even
number of masters not providing fault tolerance.

known_issues recommends 3 as a max number of masters while installation
recommended 1, 3 or 5. Changed recommendation in installation for
consistency.

Change-Id: Ic24ae1cbcd59534273adba48b20a2418651b19a4
---
M docs/administration.adoc
M docs/installation.adoc
2 files changed, 13 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/9091/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9091
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic24ae1cbcd59534273adba48b20a2418651b19a4
Gerrit-Change-Number: 9091
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>

[kudu-CR] docs: fix number of number masters

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9091 )

Change subject: docs: fix number of number masters
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/9091/3/docs/installation.adoc
File docs/installation.adoc:

http://gerrit.cloudera.org:8080/#/c/9091/3/docs/installation.adoc@45
PS3, Line 45: should always be
must be


http://gerrit.cloudera.org:8080/#/c/9091/3/docs/installation.adoc@49
PS3, Line 49: Two
For example, having two


http://gerrit.cloudera.org:8080/#/c/9091/3/docs/installation.adoc@50
PS3, Line 50: any
Not needed



-- 
To view, visit http://gerrit.cloudera.org:8080/9091
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic24ae1cbcd59534273adba48b20a2418651b19a4
Gerrit-Change-Number: 9091
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 23 Jan 2018 21:30:37 +0000
Gerrit-HasComments: Yes

[kudu-CR] docs: fix number of number masters

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Kudu Jenkins, Andrew Wong, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9091

to look at the new patch set (#3).

Change subject: docs: fix number of number masters
......................................................................

docs: fix number of number masters

Added warnings to installation and administration about having an even
number of masters not providing fault tolerance.

known_issues recommends 3 as a max number of masters while installation
recommended 1, 3 or 5. Changed recommendation in installation for
consistency.

Change-Id: Ic24ae1cbcd59534273adba48b20a2418651b19a4
---
M docs/administration.adoc
M docs/installation.adoc
2 files changed, 14 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/9091/3
-- 
To view, visit http://gerrit.cloudera.org:8080/9091
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic24ae1cbcd59534273adba48b20a2418651b19a4
Gerrit-Change-Number: 9091
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] docs: fix number of number masters

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Kudu Jenkins, Andrew Wong, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9091

to look at the new patch set (#6).

Change subject: docs: fix number of number masters
......................................................................

docs: fix number of number masters

Added warnings to installation and administration about having an even
number of masters not providing fault tolerance.

known_issues recommends 3 as a max number of masters while installation
recommended 1, 3 or 5. Changed recommendation in installation for
consistency.

Change-Id: Ic24ae1cbcd59534273adba48b20a2418651b19a4
---
M docs/administration.adoc
M docs/installation.adoc
2 files changed, 13 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/9091/6
-- 
To view, visit http://gerrit.cloudera.org:8080/9091
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic24ae1cbcd59534273adba48b20a2418651b19a4
Gerrit-Change-Number: 9091
Gerrit-PatchSet: 6
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] docs: fix number of number masters

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9091 )

Change subject: docs: fix number of number masters
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9091/3/docs/installation.adoc
File docs/installation.adoc:

http://gerrit.cloudera.org:8080/#/c/9091/3/docs/installation.adoc@49
PS3, Line 49: Two
> For example, having two
I would keep this as "two" because other even numbers do provide fault tolerance technically.



-- 
To view, visit http://gerrit.cloudera.org:8080/9091
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic24ae1cbcd59534273adba48b20a2418651b19a4
Gerrit-Change-Number: 9091
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 24 Jan 2018 10:01:54 +0000
Gerrit-HasComments: Yes

[kudu-CR] docs: fix number of number masters

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9091 )

Change subject: docs: fix number of number masters
......................................................................


Patch Set 8: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9091
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic24ae1cbcd59534273adba48b20a2418651b19a4
Gerrit-Change-Number: 9091
Gerrit-PatchSet: 8
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 21 Mar 2018 19:09:46 +0000
Gerrit-HasComments: No

[kudu-CR] docs: fix number of number masters

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9091 )

Change subject: docs: fix number of number masters
......................................................................


Patch Set 3:

Which version of Kudu is this for? Current 1.6? 

Is there a JIRA id for this?


-- 
To view, visit http://gerrit.cloudera.org:8080/9091
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic24ae1cbcd59534273adba48b20a2418651b19a4
Gerrit-Change-Number: 9091
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 24 Jan 2018 00:48:38 +0000
Gerrit-HasComments: No

[kudu-CR] docs: fix number of number masters

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9091 )

Change subject: docs: fix number of number masters
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/9091/1/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/9091/1/docs/administration.adoc@207
PS1, Line 207: multiple odd number
this sounds a little funny to me. I think it's clearer to split into two sentences, "with at least three masters. Note that the number of masters must be odd."


http://gerrit.cloudera.org:8080/#/c/9091/1/docs/administration.adoc@214
PS1, Line 214:  one less masters
"one fewer master"

Split before "this" with a period and a new sentence


http://gerrit.cloudera.org:8080/#/c/9091/1/docs/installation.adoc
File docs/installation.adoc:

http://gerrit.cloudera.org:8080/#/c/9091/1/docs/installation.adoc@49
PS1, Line 49: one less masters
one fewer master



-- 
To view, visit http://gerrit.cloudera.org:8080/9091
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic24ae1cbcd59534273adba48b20a2418651b19a4
Gerrit-Change-Number: 9091
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 22 Jan 2018 16:58:28 +0000
Gerrit-HasComments: Yes

[kudu-CR] docs: fix number of number masters

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9091 )

Change subject: docs: fix number of number masters
......................................................................


Patch Set 4:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/9091/1/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/9091/1/docs/administration.adoc@207
PS1, Line 207: three masters. Note
> this sounds a little funny to me. I think it's clearer to split into two se
Done


http://gerrit.cloudera.org:8080/#/c/9091/1/docs/administration.adoc@214
PS1, Line 214: e fewer masters. 
> "one fewer master"
Done


http://gerrit.cloudera.org:8080/#/c/9091/3/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/9091/3/docs/administration.adoc@206
PS3, Line 206: 
> nit: elsewhere in this doc, we spell out "three" (particularly since the nu
Done


http://gerrit.cloudera.org:8080/#/c/9091/3/docs/administration.adoc@215
PS3, Line 215: one to
> nit: here too
Done


http://gerrit.cloudera.org:8080/#/c/9091/1/docs/installation.adoc
File docs/installation.adoc:

http://gerrit.cloudera.org:8080/#/c/9091/1/docs/installation.adoc@49
PS1, Line 49: one fewer master
> one fewer master
Done


http://gerrit.cloudera.org:8080/#/c/9091/3/docs/installation.adoc
File docs/installation.adoc:

http://gerrit.cloudera.org:8080/#/c/9091/3/docs/installation.adoc@45
PS3, Line 45: must be odd.
> must be
Done


http://gerrit.cloudera.org:8080/#/c/9091/3/docs/installation.adoc@50
PS3, Line 50: fau
> Not needed
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/9091
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic24ae1cbcd59534273adba48b20a2418651b19a4
Gerrit-Change-Number: 9091
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 24 Jan 2018 13:11:06 +0000
Gerrit-HasComments: Yes

[kudu-CR] docs: fix number of number masters

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9091 )

Change subject: docs: fix number of number masters
......................................................................

docs: fix number of number masters

Added warnings to installation and administration about having an even
number of masters not providing fault tolerance.

known_issues recommends 3 as a max number of masters while installation
recommended 1, 3 or 5. Changed recommendation in installation for
consistency.

Change-Id: Ic24ae1cbcd59534273adba48b20a2418651b19a4
Reviewed-on: http://gerrit.cloudera.org:8080/9091
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M docs/administration.adoc
M docs/installation.adoc
2 files changed, 12 insertions(+), 5 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Dan Burkert: Looks good to me, approved
  Andrew Wong: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/9091
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic24ae1cbcd59534273adba48b20a2418651b19a4
Gerrit-Change-Number: 9091
Gerrit-PatchSet: 9
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] docs: fix number of number masters

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9091 )

Change subject: docs: fix number of number masters
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9091/3/docs/installation.adoc
File docs/installation.adoc:

http://gerrit.cloudera.org:8080/#/c/9091/3/docs/installation.adoc@49
PS3, Line 49: Two
> I would keep this as "two" because other even numbers do provide fault tole
Hm, might be a bit wordy, but how about:
"A deployment with an even number of masters provides the same level of fault tolerance as a deployment with one fewer master. For example, both four-master and three-master deployments can only tolerate a single failure; two-master deployments cannot tolerate any failures."



-- 
To view, visit http://gerrit.cloudera.org:8080/9091
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic24ae1cbcd59534273adba48b20a2418651b19a4
Gerrit-Change-Number: 9091
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 25 Jan 2018 19:50:22 +0000
Gerrit-HasComments: Yes

[kudu-CR] docs: fix number of number masters

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Kudu Jenkins, Andrew Wong, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9091

to look at the new patch set (#7).

Change subject: docs: fix number of number masters
......................................................................

docs: fix number of number masters

Added warnings to installation and administration about having an even
number of masters not providing fault tolerance.

known_issues recommends 3 as a max number of masters while installation
recommended 1, 3 or 5. Changed recommendation in installation for
consistency.

Change-Id: Ic24ae1cbcd59534273adba48b20a2418651b19a4
---
M docs/administration.adoc
M docs/installation.adoc
2 files changed, 12 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/9091/7
-- 
To view, visit http://gerrit.cloudera.org:8080/9091
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic24ae1cbcd59534273adba48b20a2418651b19a4
Gerrit-Change-Number: 9091
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] docs: fix number of number masters

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Dan Burkert, Kudu Jenkins, Andrew Wong, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9091

to look at the new patch set (#8).

Change subject: docs: fix number of number masters
......................................................................

docs: fix number of number masters

Added warnings to installation and administration about having an even
number of masters not providing fault tolerance.

known_issues recommends 3 as a max number of masters while installation
recommended 1, 3 or 5. Changed recommendation in installation for
consistency.

Change-Id: Ic24ae1cbcd59534273adba48b20a2418651b19a4
---
M docs/administration.adoc
M docs/installation.adoc
2 files changed, 12 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/9091/8
-- 
To view, visit http://gerrit.cloudera.org:8080/9091
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic24ae1cbcd59534273adba48b20a2418651b19a4
Gerrit-Change-Number: 9091
Gerrit-PatchSet: 8
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] docs: fix number of number masters

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Kudu Jenkins, Andrew Wong, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9091

to look at the new patch set (#5).

Change subject: docs: fix number of number masters
......................................................................

docs: fix number of number masters

Added warnings to installation and administration about having an even
number of masters not providing fault tolerance.

known_issues recommends 3 as a max number of masters while installation
recommended 1, 3 or 5. Changed recommendation in installation for
consistency.

Change-Id: Ic24ae1cbcd59534273adba48b20a2418651b19a4
---
M docs/administration.adoc
M docs/installation.adoc
2 files changed, 14 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/9091/5
-- 
To view, visit http://gerrit.cloudera.org:8080/9091
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic24ae1cbcd59534273adba48b20a2418651b19a4
Gerrit-Change-Number: 9091
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] docs: fix number of number masters

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9091 )

Change subject: docs: fix number of number masters
......................................................................


Patch Set 8: Code-Review+2

LGTM, but I'll wait to merge for Adar or other signoff.


-- 
To view, visit http://gerrit.cloudera.org:8080/9091
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic24ae1cbcd59534273adba48b20a2418651b19a4
Gerrit-Change-Number: 9091
Gerrit-PatchSet: 8
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 21 Mar 2018 13:13:35 +0000
Gerrit-HasComments: No

[kudu-CR] docs: fix number of number masters

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9091 )

Change subject: docs: fix number of number masters
......................................................................


Patch Set 5:

(1 comment)

> Patch Set 4:
> 
> (1 comment)

http://gerrit.cloudera.org:8080/#/c/9091/3/docs/installation.adoc
File docs/installation.adoc:

http://gerrit.cloudera.org:8080/#/c/9091/3/docs/installation.adoc@49
PS3, Line 49: e a
> Hm, might be a bit wordy, but how about:
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/9091
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic24ae1cbcd59534273adba48b20a2418651b19a4
Gerrit-Change-Number: 9091
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 30 Jan 2018 21:24:31 +0000
Gerrit-HasComments: Yes

[kudu-CR] docs: fix number of number masters

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9091 )

Change subject: docs: fix number of number masters
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9091/3/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/9091/3/docs/administration.adoc@206
PS3, Line 206: 3
nit: elsewhere in this doc, we spell out "three" (particularly since the number is so small)


http://gerrit.cloudera.org:8080/#/c/9091/3/docs/administration.adoc@215
PS3, Line 215: 1 to 3
nit: here too



-- 
To view, visit http://gerrit.cloudera.org:8080/9091
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic24ae1cbcd59534273adba48b20a2418651b19a4
Gerrit-Change-Number: 9091
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 23 Jan 2018 19:04:07 +0000
Gerrit-HasComments: Yes

[kudu-CR] docs: fix number of number masters

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Kudu Jenkins, Andrew Wong, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9091

to look at the new patch set (#4).

Change subject: docs: fix number of number masters
......................................................................

docs: fix number of number masters

Added warnings to installation and administration about having an even
number of masters not providing fault tolerance.

known_issues recommends 3 as a max number of masters while installation
recommended 1, 3 or 5. Changed recommendation in installation for
consistency.

Change-Id: Ic24ae1cbcd59534273adba48b20a2418651b19a4
---
M docs/administration.adoc
M docs/installation.adoc
2 files changed, 13 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/9091/4
-- 
To view, visit http://gerrit.cloudera.org:8080/9091
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic24ae1cbcd59534273adba48b20a2418651b19a4
Gerrit-Change-Number: 9091
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] docs: fix number of number masters

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Kudu Jenkins, Andrew Wong, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9091

to look at the new patch set (#2).

Change subject: docs: fix number of number masters
......................................................................

docs: fix number of number masters

Added warnings to installation and administration about having an even
number of masters not providing fault tolerance.

known_issues recommends 3 as a max number of masters while installation
recommended 1, 3 or 5. Changed recommendation in installation for
consistency.

Change-Id: Ic24ae1cbcd59534273adba48b20a2418651b19a4
---
M docs/administration.adoc
M docs/installation.adoc
2 files changed, 14 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/9091/2
-- 
To view, visit http://gerrit.cloudera.org:8080/9091
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic24ae1cbcd59534273adba48b20a2418651b19a4
Gerrit-Change-Number: 9091
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>