You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@helix.apache.org by "Kanak Biscuitwala (JIRA)" <ji...@apache.org> on 2013/08/22 22:37:52 UTC

[jira] [Commented] (HELIX-204) Remove all direct usage on ZNRecord outside of model package

    [ https://issues.apache.org/jira/browse/HELIX-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747865#comment-13747865 ] 

Kanak Biscuitwala commented on HELIX-204:
-----------------------------------------

This is a huge change; if I move ZNRecord to model right now and make it package-private, there are over 2000 errors. There are a few types of usage to deal with here:

1. Not using the model at all
2. Using the model, but converting it back to ZNRecord for ZK writes
3. Mixed usage of model and ZNRecord, often through getRecord()

I'll create subtasks to keep changelist sizes relatively small and ensure gradual improvement of this situation.
                
> Remove all direct usage on ZNRecord outside of model package
> ------------------------------------------------------------
>
>                 Key: HELIX-204
>                 URL: https://issues.apache.org/jira/browse/HELIX-204
>             Project: Apache Helix
>          Issue Type: Task
>          Components: helix-core
>            Reporter: kishore gopalakrishna
>            Assignee: Kanak Biscuitwala
>
> Currently most of the classes in model package are not completely done. They are just place holders and we directly use the ZNRecord.
> If we make move ZNRecord in model package and make it package accessible only, then we can enforce that one can only use model classes 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira