You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "David Mollitor (Jira)" <ji...@apache.org> on 2020/10/08 16:32:00 UTC

[jira] [Created] (PARQUET-1921) Use StringBuilder instead of StringBuffer

David Mollitor created PARQUET-1921:
---------------------------------------

             Summary: Use StringBuilder instead of StringBuffer
                 Key: PARQUET-1921
                 URL: https://issues.apache.org/jira/browse/PARQUET-1921
             Project: Parquet
          Issue Type: Improvement
          Components: parquet-mr
            Reporter: David Mollitor


{code:java|title=MessageTypeParser.java}
    private StringBuffer currentLine = new StringBuffer();

    ....

    public String nextToken() {
      while (st.hasMoreTokens()) {
        String t = st.nextToken();
        if (t.equals("\n")) {
          ++ line;
          currentLine.setLength(0);
        } else {
          currentLine.append(t);
        }
        if (!isWhitespace(t)) {
          return t;
        }
      }
      throw new IllegalArgumentException("unexpected end of schema");
    }
{code}

Use {{StringBuilder}} instead of {{StringBuffer}} as {{StringBuffer}} is synchronized (which is not required here).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)