You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by dk...@apache.org on 2018/03/06 16:40:08 UTC

tinkerpop git commit: Generate SHA-512 checksums for release artifacts, instead of MD5 and SHA-1. This change was suggested by The Apache Software Foundation.

Repository: tinkerpop
Updated Branches:
  refs/heads/TINKERPOP-1912 [created] 5f2e8801d


Generate SHA-512 checksums for release artifacts, instead of MD5 and SHA-1.
This change was suggested by The Apache Software Foundation.


Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/5f2e8801
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/5f2e8801
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/5f2e8801

Branch: refs/heads/TINKERPOP-1912
Commit: 5f2e8801d8ab4a107b8064784c5779cde191be01
Parents: aaf5146
Author: Daniel Kuppitz <da...@hotmail.com>
Authored: Tue Mar 6 09:38:14 2018 -0700
Committer: Daniel Kuppitz <da...@hotmail.com>
Committed: Tue Mar 6 09:38:14 2018 -0700

----------------------------------------------------------------------
 bin/validate-distribution.sh            |  8 +-------
 docs/src/dev/developer/release.asciidoc |  2 +-
 pom.xml                                 | 17 +++++++++++++++++
 3 files changed, 19 insertions(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/5f2e8801/bin/validate-distribution.sh
----------------------------------------------------------------------
diff --git a/bin/validate-distribution.sh b/bin/validate-distribution.sh
index 0121a1a..854efc6 100755
--- a/bin/validate-distribution.sh
+++ b/bin/validate-distribution.sh
@@ -83,7 +83,7 @@ fi
 
 echo -n "* downloading ${COMPONENT} (${ZIP_FILENAME})... "
 curl -Lsf ${URL} -o ${ZIP_FILENAME} || { echo "Failed to download ${COMPONENT}" ; exit 1; }
-for ext in "asc" "md5" "sha1"
+for ext in "asc" "sha256"
 do
   curl -Lsf ${URL}.${ext} -o ${ZIP_FILENAME}.${ext} || { echo "Failed to download ${COMPONENT} (${ext})" ; exit 1 ; }
 done
@@ -100,12 +100,6 @@ echo -n "  * PGP signature ... "
 { echo "failed"; exit 1; }
 echo "OK"
 
-echo -n "  * MD5 checksum ... "
-EXPECTED=`cat ${ZIP_FILENAME}.md5`
-ACTUAL=`md5sum ${ZIP_FILENAME} | awk '{print $1}'`
-[ "$ACTUAL" = "${EXPECTED}" ] || { echo "failed"; exit 1; }
-echo "OK"
-
 echo -n "  * SHA1 checksum ... "
 EXPECTED=`cat ${ZIP_FILENAME}.sha1`
 ACTUAL=`sha1sum ${ZIP_FILENAME} | awk '{print $1}'`

http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/5f2e8801/docs/src/dev/developer/release.asciidoc
----------------------------------------------------------------------
diff --git a/docs/src/dev/developer/release.asciidoc b/docs/src/dev/developer/release.asciidoc
index fab9819..0ce305f 100644
--- a/docs/src/dev/developer/release.asciidoc
+++ b/docs/src/dev/developer/release.asciidoc
@@ -201,7 +201,7 @@ current release was under development as this new release will have those change
 . `bin/publish-docs.sh <username>` - Note that this step requires no additional processing as the previous step handled
 document generation and this step now merely needs to upload what was generated. Note that this step will be responsible
 for generating javadoc and without that the binary distributions won't contain that documentation.
-. `mvn deploy -Papache-release -DcreateChecksum=true -DskipTests` - deploy signed artifacts with checksums to link:https://repository.apache.org/[Apache Nexus].
+. `mvn deploy -Papache-release -DskipTests` - deploy signed artifacts with checksums to link:https://repository.apache.org/[Apache Nexus].
 . Review generated artifacts to be sure they have both javadocs and asciidocs present (request another committer to review as well) then "close" the repo - if the repo is left open it will be automatically dropped after five days and closing the repo will allow it to stay available for a full ninety days which is more than enough time to complete a vote. Do NOT "release" the repository at this time.
 . Upload artifacts to `https://dist.apache.org/repos/dist/dev/tinkerpop` for `[VOTE]` review.
 .. Use `svn rm` to delete past versions that were up for review in the same line of code. In other words, if uploading 3.2.3 then remove instances of 3.2.2 or any other past 3.2.x releases.

http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/5f2e8801/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index f6ff536..1fe788a 100644
--- a/pom.xml
+++ b/pom.xml
@@ -271,6 +271,23 @@ limitations under the License.
                 </configuration>
             </plugin>
             <plugin>
+                <groupId>net.nicoulaj.maven.plugins</groupId>
+                <artifactId>checksum-maven-plugin</artifactId>
+                <version>1.6</version>
+                <executions>
+                    <execution>
+                        <goals>
+                            <goal>artifacts</goal>
+                        </goals>
+                    </execution>
+                </executions>
+                <configuration>
+                    <algorithms>
+                        <algorithm>SHA-512</algorithm>
+                    </algorithms>
+                </configuration>
+            </plugin>
+            <plugin>
                 <groupId>org.apache.rat</groupId>
                 <artifactId>apache-rat-plugin</artifactId>
                 <version>0.12</version>