You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Qian Xu <sx...@googlemail.com> on 2014/10/14 18:12:43 UTC

Review Request 26692: SQOOP-1391: Compression Codec Handling

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26692/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-1391
    https://issues.apache.org/jira/browse/SQOOP-1391


Repository: sqoop-trunk


Description
-------

Allow user specify `snappy` or 'deflate' as compression codec


Diffs
-----

  ivy.xml b77adeb 
  ivy/libraries.properties 8f98739 
  src/java/org/apache/sqoop/mapreduce/ImportJobBase.java dab5606 
  src/java/org/apache/sqoop/mapreduce/ParquetJob.java 6ef29a1 
  src/test/com/cloudera/sqoop/TestParquetImport.java 2224719 

Diff: https://reviews.apache.org/r/26692/diff/


Testing
-------

New tests added. All tests passed.


Thanks,

Qian Xu

Re: Review Request 26692: SQOOP-1391: Compression Codec Handling

Posted by Tom White <to...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26692/#review59336
-----------------------------------------------------------

Ship it!


- Tom White


On Oct. 27, 2014, 2:50 a.m., Qian Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26692/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2014, 2:50 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1391
>     https://issues.apache.org/jira/browse/SQOOP-1391
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Allow user specify `snappy` or 'deflate' as compression codec
> 
> 
> Diffs
> -----
> 
>   ivy.xml b77adeb 
>   ivy/libraries.properties 8f98739 
>   src/java/org/apache/sqoop/mapreduce/ImportJobBase.java dab5606 
>   src/java/org/apache/sqoop/mapreduce/ParquetJob.java 6ef29a1 
>   src/test/com/cloudera/sqoop/TestParquetImport.java 2224719 
> 
> Diff: https://reviews.apache.org/r/26692/diff/
> 
> 
> Testing
> -------
> 
> New tests added. All tests passed.
> 
> 
> Thanks,
> 
> Qian Xu
> 
>

Re: Review Request 26692: SQOOP-1391: Compression Codec Handling

Posted by Qian Xu <sx...@googlemail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26692/
-----------------------------------------------------------

(Updated Oct. 27, 2014, 10:50 a.m.)


Review request for Sqoop.


Changes
-------

updated two things according to tom's comments


Bugs: SQOOP-1391
    https://issues.apache.org/jira/browse/SQOOP-1391


Repository: sqoop-trunk


Description
-------

Allow user specify `snappy` or 'deflate' as compression codec


Diffs (updated)
-----

  ivy.xml b77adeb 
  ivy/libraries.properties 8f98739 
  src/java/org/apache/sqoop/mapreduce/ImportJobBase.java dab5606 
  src/java/org/apache/sqoop/mapreduce/ParquetJob.java 6ef29a1 
  src/test/com/cloudera/sqoop/TestParquetImport.java 2224719 

Diff: https://reviews.apache.org/r/26692/diff/


Testing
-------

New tests added. All tests passed.


Thanks,

Qian Xu

Re: Review Request 26692: SQOOP-1391: Compression Codec Handling

Posted by Tom White <to...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26692/#review58267
-----------------------------------------------------------


Looks good, just a couple of comments.


src/java/org/apache/sqoop/mapreduce/ParquetJob.java
<https://reviews.apache.org/r/26692/#comment99219>

    CONF_OUTPUT_CODEC could be package private rather than public.



src/test/com/cloudera/sqoop/TestParquetImport.java
<https://reviews.apache.org/r/26692/#comment99220>

    Can you test that the dataset has the expected codec too?


- Tom White


On Oct. 14, 2014, 4:12 p.m., Qian Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26692/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2014, 4:12 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1391
>     https://issues.apache.org/jira/browse/SQOOP-1391
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Allow user specify `snappy` or 'deflate' as compression codec
> 
> 
> Diffs
> -----
> 
>   ivy.xml b77adeb 
>   ivy/libraries.properties 8f98739 
>   src/java/org/apache/sqoop/mapreduce/ImportJobBase.java dab5606 
>   src/java/org/apache/sqoop/mapreduce/ParquetJob.java 6ef29a1 
>   src/test/com/cloudera/sqoop/TestParquetImport.java 2224719 
> 
> Diff: https://reviews.apache.org/r/26692/diff/
> 
> 
> Testing
> -------
> 
> New tests added. All tests passed.
> 
> 
> Thanks,
> 
> Qian Xu
> 
>