You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/07/19 04:28:37 UTC
[GitHub] [pulsar] wolfstudy commented on a change in pull request #4746: [go
function] fix: go function should parse conf content first
wolfstudy commented on a change in pull request #4746: [go function] fix: go function should parse conf content first
URL: https://github.com/apache/pulsar/pull/4746#discussion_r305198109
##########
File path: pulsar-function-go/conf/conf.go
##########
@@ -80,14 +80,34 @@ var (
confContent string
)
+func fileExists(path string) bool {
+ if path == "" {
+ return false
+ }
+ _, err := os.Stat(path)
+ if err != nil && os.IsNotExist(err) {
Review comment:
I think the logic is right, the check logic is `err != nil && os.IsNotExist(err)` instead of `err != nil && ! os.IsNotExist(err)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services