You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2018/03/28 08:55:53 UTC
[kudu-CR] Introduce samples directory
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9837
Change subject: Introduce samples directory
......................................................................
Introduce samples directory
This introduces the top-level samples directory, which will be for
samples of how to use the Kudu clients and integrations.
As a first step, I moved the client samples from src/kudu/client/samples
to samples/cpp.
I also manually verified that the instructions in the README for building the
sample application still work.
Change-Id: Iceca48771541f95e4f0caf8c098bc85d34aa558e
---
R samples/cpp/CMakeLists.txt
R samples/cpp/README.adoc
R samples/cpp/sample.cc
M src/kudu/client/CMakeLists.txt
4 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/9837/1
--
To view, visit http://gerrit.cloudera.org:8080/9837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iceca48771541f95e4f0caf8c098bc85d34aa558e
Gerrit-Change-Number: 9837
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] Introduce examples directory
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9837
to look at the new patch set (#2).
Change subject: Introduce examples directory
......................................................................
Introduce examples directory
This introduces the top-level examples directory, which will be for
examples of how to use the Kudu clients and integrations.
As a first step, I moved the client examples from src/kudu/client/examples
to examples/cpp. I also renamed "sample" -> "example" generally.
I also manually verified that the instructions in the README for building the
example application still work.
Change-Id: Iceca48771541f95e4f0caf8c098bc85d34aa558e
---
R examples/cpp/CMakeLists.txt
R examples/cpp/README.adoc
R examples/cpp/example.cc
M src/kudu/client/CMakeLists.txt
R src/kudu/client/client_examples-test.sh
5 files changed, 49 insertions(+), 49 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/9837/2
--
To view, visit http://gerrit.cloudera.org:8080/9837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iceca48771541f95e4f0caf8c098bc85d34aa558e
Gerrit-Change-Number: 9837
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] Introduce examples directory
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9837 )
Change subject: Introduce examples directory
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iceca48771541f95e4f0caf8c098bc85d34aa558e
Gerrit-Change-Number: 9837
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Wed, 28 Mar 2018 21:23:54 +0000
Gerrit-HasComments: No
[kudu-CR] Introduce examples directory
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9837 )
Change subject: Introduce examples directory
......................................................................
Introduce examples directory
This introduces the top-level examples directory, which will be for
examples of how to use the Kudu clients and integrations.
As a first step, I moved the client examples from src/kudu/client/examples
to examples/cpp. I also renamed "sample" -> "example" generally.
I also manually verified that the instructions in the README for building the
example application still work.
Change-Id: Iceca48771541f95e4f0caf8c098bc85d34aa558e
Reviewed-on: http://gerrit.cloudera.org:8080/9837
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
R examples/cpp/CMakeLists.txt
R examples/cpp/README.adoc
R examples/cpp/example.cc
M src/kudu/client/CMakeLists.txt
R src/kudu/client/client_examples-test.sh
5 files changed, 49 insertions(+), 49 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iceca48771541f95e4f0caf8c098bc85d34aa558e
Gerrit-Change-Number: 9837
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] Introduce samples directory
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9837 )
Change subject: Introduce samples directory
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9837/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9837/1//COMMIT_MSG@7
PS1, Line 7: Introduce samples directory
> I know this bike-sheddy, but now is probably the past time to discuss this:
+1
--
To view, visit http://gerrit.cloudera.org:8080/9837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iceca48771541f95e4f0caf8c098bc85d34aa558e
Gerrit-Change-Number: 9837
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Wed, 28 Mar 2018 18:22:54 +0000
Gerrit-HasComments: Yes
[kudu-CR] Introduce samples directory
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9837 )
Change subject: Introduce samples directory
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9837/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9837/1//COMMIT_MSG@7
PS1, Line 7: Introduce samples directory
I know this bike-sheddy, but now is probably the past time to discuss this: I'd prefer 'examples' over 'samples'. The latter could be confused with other uses of the word 'sample' (like "statistical sampling"), while the former is unambiguous.
--
To view, visit http://gerrit.cloudera.org:8080/9837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iceca48771541f95e4f0caf8c098bc85d34aa558e
Gerrit-Change-Number: 9837
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Wed, 28 Mar 2018 16:10:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] Introduce examples directory
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9837 )
Change subject: Introduce examples directory
......................................................................
Patch Set 2: Code-Review+2
The only downside to renaming the test itself is losing flakiness history, but I don't think client_samples-test was every flaky, so it probably doesn't matter.
--
To view, visit http://gerrit.cloudera.org:8080/9837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iceca48771541f95e4f0caf8c098bc85d34aa558e
Gerrit-Change-Number: 9837
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Wed, 28 Mar 2018 18:54:42 +0000
Gerrit-HasComments: No