You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/09/10 00:20:07 UTC
Re: Review Request 38028: [1/5] Integer Precision for JSON <->
Protobuf conversions.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38028/
-----------------------------------------------------------
(Updated Sept. 9, 2015, 3:20 p.m.)
Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
Changes
-------
Ready for wider review.
Summary (updated)
-----------------
[1/5] Integer Precision for JSON <-> Protobuf conversions.
Bugs: MESOS-3345
https://issues.apache.org/jira/browse/MESOS-3345
Repository: mesos
Description
-------
Updates PicoJSON to version 1.3.0 and adds a -DPICOJSON_USE_INT64 flag to the compilation flags.
Diffs
-----
3rdparty/libprocess/3rdparty/CMakeLists.txt 997cc0d
3rdparty/libprocess/3rdparty/Makefile.am eb34251
3rdparty/libprocess/3rdparty/picojson-1.3.0.tar.gz PRE-CREATION
3rdparty/libprocess/3rdparty/picojson-4f93734.tar.gz f52dacd1c51ef5c533d174f63539a9b25e3d9180
3rdparty/libprocess/3rdparty/versions.am f44c715
3rdparty/libprocess/Makefile.am 6361ac6
Diff: https://reviews.apache.org/r/38028/diff/
Testing (updated)
-------
No testing done until the last patch in the chain.
Thanks,
Joseph Wu
Re: Review Request 38028: [1/5] Integer Precision for JSON <->
Protobuf conversions.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38028/#review98281
-----------------------------------------------------------
Ship it!
- Joris Van Remoortere
On Sept. 9, 2015, 10:20 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38028/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2015, 10:20 p.m.)
>
>
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
>
>
> Bugs: MESOS-3345
> https://issues.apache.org/jira/browse/MESOS-3345
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updates PicoJSON to version 1.3.0 and adds a -DPICOJSON_USE_INT64 flag to the compilation flags.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/CMakeLists.txt 997cc0d
> 3rdparty/libprocess/3rdparty/Makefile.am eb34251
> 3rdparty/libprocess/3rdparty/picojson-1.3.0.tar.gz PRE-CREATION
> 3rdparty/libprocess/3rdparty/picojson-4f93734.tar.gz f52dacd1c51ef5c533d174f63539a9b25e3d9180
> 3rdparty/libprocess/3rdparty/versions.am f44c715
> 3rdparty/libprocess/Makefile.am 6361ac6
>
> Diff: https://reviews.apache.org/r/38028/diff/
>
>
> Testing
> -------
>
> No testing done until the last patch in the chain.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 38028: [1/5] Integer Precision for JSON <->
Protobuf conversions.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38028/
-----------------------------------------------------------
(Updated Sept. 17, 2015, 12:13 p.m.)
Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
Changes
-------
Re-opening with fixes for g++ 4.8/4.9 on CentOS 7.
Bugs: MESOS-3345
https://issues.apache.org/jira/browse/MESOS-3345
Repository: mesos
Description (updated)
-------
Updates PicoJson to version 1.3.0 and adds `PICOJSON_USE_INT64` and `__STDC_FORMAT_MACROS` flags to the compilation flags.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/CMakeLists.txt d13ba666740b4f2e382a0b1852724cfd519f8f64
3rdparty/libprocess/3rdparty/Makefile.am eb34251d24b1e5d1540151b59cf1062ca85aeb03
3rdparty/libprocess/3rdparty/picojson-1.3.0.tar.gz PRE-CREATION
3rdparty/libprocess/3rdparty/picojson-4f93734.tar.gz f52dacd1c51ef5c533d174f63539a9b25e3d9180
3rdparty/libprocess/3rdparty/versions.am f44c7153166225279b973615ef0441c6f945da5b
3rdparty/libprocess/Makefile.am 064310c61d8a0c5c5a87f305f1f62149dd3a6699
Diff: https://reviews.apache.org/r/38028/diff/
Testing
-------
No testing done until the last patch in the chain.
Thanks,
Joseph Wu
Re: Review Request 38028: [1/5] Integer Precision for JSON <->
Protobuf conversions.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38028/
-----------------------------------------------------------
(Updated Sept. 11, 2015, 10:42 a.m.)
Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
Changes
-------
Rebase due to test fix and merge conflict.
Bugs: MESOS-3345
https://issues.apache.org/jira/browse/MESOS-3345
Repository: mesos
Description
-------
Updates PicoJSON to version 1.3.0 and adds a -DPICOJSON_USE_INT64 flag to the compilation flags.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/CMakeLists.txt d13ba66
3rdparty/libprocess/3rdparty/Makefile.am eb34251
3rdparty/libprocess/3rdparty/picojson-1.3.0.tar.gz PRE-CREATION
3rdparty/libprocess/3rdparty/picojson-4f93734.tar.gz f52dacd1c51ef5c533d174f63539a9b25e3d9180
3rdparty/libprocess/3rdparty/versions.am f44c715
3rdparty/libprocess/Makefile.am 6361ac6
Diff: https://reviews.apache.org/r/38028/diff/
Testing
-------
No testing done until the last patch in the chain.
Thanks,
Joseph Wu