You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oodt.apache.org by Michael Starch <st...@umich.edu> on 2014/10/25 00:32:30 UTC

Review Request 27172: Filemanager Changes for Streaming OODT Changes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27172/
-----------------------------------------------------------

Review request for oodt and Chris Mattmann.


Repository: oodt


Description
-------

A sub-patch habdling the filemanager components of https://reviews.apache.org/r/22791/

These changes will not affect other users with the small exception that there is now a "guard clause" in setProductStructure.  Thus if a user specifies an invalid product structure, they will get an error.  Anything that is broken by this is effectively a bug.  Three tests have been updated to remove bugs descovered by this guard-clause.

All other changes add functionality for the new STREAM structure.  All recommendations from: https://reviews.apache.org/r/22791/ have been fixed.

These changes are a preparation step for SOODT.


Diffs
-----

  trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/IngestProductCliAction.java 1634141 
  trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/LocalDataTransferer.java 1634141 
  trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/metadata/extractors/CoreMetExtractor.java 1634141 
  trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/Product.java 1634141 
  trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/Reference.java 1634141 
  trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/system/XmlRpcFileManager.java 1634141 
  trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/versioning/BasicVersioner.java 1634141 
  trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/versioning/DateTimeVersioner.java 1634141 
  trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/versioning/SingleFileBasicVersioner.java 1634141 
  trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/versioning/VersioningUtils.java 1634141 
  trunk/webapp/fmprod/src/test/java/org/apache/oodt/cas/product/jaxrs/resources/ProductResourceTest.java 1634141 
  trunk/webapp/fmprod/src/test/java/org/apache/oodt/cas/product/jaxrs/resources/TransferResourceTest.java 1634141 
  trunk/webapp/fmprod/src/test/java/org/apache/oodt/cas/product/jaxrs/resources/TransfersResourceTest.java 1634141 

Diff: https://reviews.apache.org/r/27172/diff/


Testing
-------

Build and ran unit tests these pass.  Testing was done to check the new STREAM type, it works.  


Thanks,

Michael Starch

Re: Review Request 27172: Filemanager Changes for Streaming OODT Changes

Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27172/#review58499
-----------------------------------------------------------

Ship it!


Ship It!

- Chris Mattmann


On Oct. 24, 2014, 10:32 p.m., Michael Starch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27172/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2014, 10:32 p.m.)
> 
> 
> Review request for oodt and Chris Mattmann.
> 
> 
> Repository: oodt
> 
> 
> Description
> -------
> 
> A sub-patch habdling the filemanager components of https://reviews.apache.org/r/22791/
> 
> These changes will not affect other users with the small exception that there is now a "guard clause" in setProductStructure.  Thus if a user specifies an invalid product structure, they will get an error.  Anything that is broken by this is effectively a bug.  Three tests have been updated to remove bugs descovered by this guard-clause.
> 
> All other changes add functionality for the new STREAM structure.  All recommendations from: https://reviews.apache.org/r/22791/ have been fixed.
> 
> These changes are a preparation step for SOODT.
> 
> 
> Diffs
> -----
> 
>   trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/IngestProductCliAction.java 1634141 
>   trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/LocalDataTransferer.java 1634141 
>   trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/metadata/extractors/CoreMetExtractor.java 1634141 
>   trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/Product.java 1634141 
>   trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/Reference.java 1634141 
>   trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/system/XmlRpcFileManager.java 1634141 
>   trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/versioning/BasicVersioner.java 1634141 
>   trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/versioning/DateTimeVersioner.java 1634141 
>   trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/versioning/SingleFileBasicVersioner.java 1634141 
>   trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/versioning/VersioningUtils.java 1634141 
>   trunk/webapp/fmprod/src/test/java/org/apache/oodt/cas/product/jaxrs/resources/ProductResourceTest.java 1634141 
>   trunk/webapp/fmprod/src/test/java/org/apache/oodt/cas/product/jaxrs/resources/TransferResourceTest.java 1634141 
>   trunk/webapp/fmprod/src/test/java/org/apache/oodt/cas/product/jaxrs/resources/TransfersResourceTest.java 1634141 
> 
> Diff: https://reviews.apache.org/r/27172/diff/
> 
> 
> Testing
> -------
> 
> Build and ran unit tests these pass.  Testing was done to check the new STREAM type, it works.  
> 
> 
> Thanks,
> 
> Michael Starch
> 
>