You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Hive QA (JIRA)" <ji...@apache.org> on 2019/06/03 11:14:00 UTC
[jira] [Commented] (HIVE-21822) Expose LlapDaemon metrics through a
new API method
[ https://issues.apache.org/jira/browse/HIVE-21822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854480#comment-16854480 ]
Hive QA commented on HIVE-21822:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 48s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 29s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 38s{color} | {color:blue} llap-common in master has 76 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 56s{color} | {color:blue} llap-server in master has 81 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 38s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 34s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 23s{color} | {color:red} llap-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 23s{color} | {color:red} llap-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 23s{color} | {color:red} llap-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 48s{color} | {color:red} llap-common generated 6 new + 76 unchanged - 0 fixed = 82 total (was 76) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 22s{color} | {color:red} llap-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 36s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 19m 3s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:llap-common |
| | org.apache.hadoop.hive.llap.daemon.rpc.LlapDaemonProtocolProtos$GetLoadMetricsRequestProto.PARSER isn't final but should be At LlapDaemonProtocolProtos.java:be At LlapDaemonProtocolProtos.java:[line 20130] |
| | Class org.apache.hadoop.hive.llap.daemon.rpc.LlapDaemonProtocolProtos$GetLoadMetricsRequestProto defines non-transient non-serializable instance field unknownFields In LlapDaemonProtocolProtos.java:instance field unknownFields In LlapDaemonProtocolProtos.java |
| | Useless control flow in org.apache.hadoop.hive.llap.daemon.rpc.LlapDaemonProtocolProtos$GetLoadMetricsRequestProto$Builder.maybeForceBuilderInitialization() At LlapDaemonProtocolProtos.java: At LlapDaemonProtocolProtos.java:[line 20304] |
| | org.apache.hadoop.hive.llap.daemon.rpc.LlapDaemonProtocolProtos$GetLoadMetricsResponseProto.PARSER isn't final but should be At LlapDaemonProtocolProtos.java:be At LlapDaemonProtocolProtos.java:[line 20499] |
| | Class org.apache.hadoop.hive.llap.daemon.rpc.LlapDaemonProtocolProtos$GetLoadMetricsResponseProto defines non-transient non-serializable instance field unknownFields In LlapDaemonProtocolProtos.java:instance field unknownFields In LlapDaemonProtocolProtos.java |
| | Useless control flow in org.apache.hadoop.hive.llap.daemon.rpc.LlapDaemonProtocolProtos$GetLoadMetricsResponseProto$Builder.maybeForceBuilderInitialization() At LlapDaemonProtocolProtos.java: At LlapDaemonProtocolProtos.java:[line 20740] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-17394/dev-support/hive-personality.sh |
| git revision | master / 10b6d70 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-17394/yetus/patch-mvninstall-llap-server.txt |
| compile | http://104.198.109.242/logs//PreCommit-HIVE-Build-17394/yetus/patch-compile-llap-server.txt |
| javac | http://104.198.109.242/logs//PreCommit-HIVE-Build-17394/yetus/patch-compile-llap-server.txt |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-17394/yetus/new-findbugs-llap-common.html |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-17394/yetus/patch-findbugs-llap-server.txt |
| modules | C: llap-common llap-server U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-17394/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Expose LlapDaemon metrics through a new API method
> --------------------------------------------------
>
> Key: HIVE-21822
> URL: https://issues.apache.org/jira/browse/HIVE-21822
> Project: Hive
> Issue Type: Sub-task
> Components: llap
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Attachments: HIVE-21822.patch
>
>
> We should add a new API method to access specific LlapDaemon metrics which would provide information to TezAMs to make good decisions on load balancing tasks
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)