You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/25 16:23:21 UTC
[GitHub] [airflow] potiuk opened a new pull request, #25291: Remove Werkzeug limitation after flask-login was fixed
potiuk opened a new pull request, #25291:
URL: https://github.com/apache/airflow/pull/25291
The Werkzeug limitation removed in #25270 can be removed now, when
Flask-login is fixed and 0.6.2 version is released that supports it.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25291: Remove Werkzeug limitation after flask-login was fixed
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25291:
URL: https://github.com/apache/airflow/pull/25291#issuecomment-1197168873
Right. I also had to fix the tests because Werkzeug 2.2 suddenly started to return ' instead of ' :shrug:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25291: Remove Werkzeug limitation after flask-login was fixed
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25291:
URL: https://github.com/apache/airflow/pull/25291#issuecomment-1195856891
Actually, this turned to be real error @josh-fell and @jedcunningham - https://github.com/apache/airflow/pull/25318
I think this one actually can have quite a bad effect on our users, I will follow up with flask-login maintainer to verify the actual scope of the problem.
As I see now, some of our users will likely have google openid auth backend stop working if they switch to Flask-Login 0.6.2 (And there is nothing to prevent them from doing so except constraints).
However in the meantime we should merge #25318 to stop main from failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #25291: Remove Werkzeug limitation after flask-login was fixed
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25291:
URL: https://github.com/apache/airflow/pull/25291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25291: Remove Werkzeug limitation after flask-login was fixed
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25291:
URL: https://github.com/apache/airflow/pull/25291#issuecomment-1195642051
Let's not merge this one (yet) flask login 0.6.2 break one of our tests (Google Oauth login). I can reliably reprosuce it but i need to find out if it is a real bug or test issue (i presume the latter - seems like we are mocking some internal call that have changed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org