You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/09/21 14:21:43 UTC

[GitHub] [calcite] kasakrisz commented on a diff in pull request #2915: [CALCITE-5293] Support general set operators in PruneEmptyRules

kasakrisz commented on code in PR #2915:
URL: https://github.com/apache/calcite/pull/2915#discussion_r976575571


##########
core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java:
##########
@@ -94,7 +94,7 @@ public interface Config extends RelRule.Config {
   public static final RelOptRule UNION_INSTANCE =
       ImmutableUnionEmptyPruneRuleConfig.of()
           .withOperandSupplier(b0 ->
-              b0.operand(LogicalUnion.class).unorderedInputs(b1 ->
+              b0.operand(Union.class).unorderedInputs(b1 ->

Review Comment:
   Only set operator rules configured for Logical operators so it makes a bit inconsistent the default config.
   Anyway I got your point and reverted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org