You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Jonathan Gray <jg...@apache.org> on 2010/07/08 01:48:39 UTC
Review Request: First cut at a working load balancer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/282/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
Just putting this up to show people. It's not done but the balanceCluster() method "works" and has a bunch of test cases.
This addresses bug HBASE-2697.
http://issues.apache.org/jira/browse/HBASE-2697
Diffs
-----
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/HServerInfo.java 961064
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java PRE-CREATION
branches/0.90_master_rewrite/src/test/java/org/apache/hadoop/hbase/master/TestLoadBalancer.java PRE-CREATION
Diff: http://review.hbase.org/r/282/diff
Testing
-------
Added TestLoadBalancer.testLoadBalancer_balanceCluster(). If you have any good edge cases let me know!
Thanks,
Jonathan
RE: Review Request: First cut at a working load balancer
Posted by Jonathan Gray <jg...@facebook.com>.
Load balancing only uses number of regions as the load metric, there is no other concept of load, yet.
That's a target for the next iteration of load balancing but outside the scope of the current work being done.
JG
> -----Original Message-----
> From: Ted Yu [mailto:yuzhihong@gmail.com]
> Sent: Sunday, July 25, 2010 3:50 PM
> To: dev@hbase.apache.org
> Subject: Re: Review Request: First cut at a working load balancer
>
> Looking at https://issues.apache.org/jira/browse/HBASE-2697, I found
> another
> review request: http://review.hbase.org/r/382/#review476 which is
> related to
> HBASE-2692
> I am not sure whether I should comment about load balancing in HBASE-
> 2697
>
> On Sun, Jul 25, 2010 at 1:31 PM, Ted Yu <yu...@gmail.com> wrote:
>
> > Jonathan:
> > Can you elaborate on how the following information (input
> tobalanceCluster)
> > is gathered ?
> >
> > Map<HServerInfo,List<HRegionInfo>> serverInfo
> >
> > Considering the implication from HBASE-2473, some (pre-created)
> regions may
> > stay empty for some time. Would those regions be included in the
> above Map ?
> >
> > Thanks
> >
> >
> > On Wed, Jul 7, 2010 at 4:48 PM, Jonathan Gray <jg...@apache.org>
> wrote:
> >
> >>
> >> -----------------------------------------------------------
> >> This is an automatically generated e-mail. To reply, visit:
> >> http://review.hbase.org/r/282/
> >> -----------------------------------------------------------
> >>
> >> Review request for hbase.
> >>
> >>
> >> Summary
> >> -------
> >>
> >> Just putting this up to show people. It's not done but the
> >> balanceCluster() method "works" and has a bunch of test cases.
> >>
> >>
> >> This addresses bug HBASE-2697.
> >> http://issues.apache.org/jira/browse/HBASE-2697
> >>
> >>
> >> Diffs
> >> -----
> >>
> >>
> branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/HSer
> verInfo.java
> >> 961064
> >>
> branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/mast
> er/LoadBalancer.java
> >> PRE-CREATION
> >>
> branches/0.90_master_rewrite/src/test/java/org/apache/hadoop/hbase/mast
> er/TestLoadBalancer.java
> >> PRE-CREATION
> >>
> >> Diff: http://review.hbase.org/r/282/diff
> >>
> >>
> >> Testing
> >> -------
> >>
> >> Added TestLoadBalancer.testLoadBalancer_balanceCluster(). If you
> have any
> >> good edge cases let me know!
> >>
> >>
> >> Thanks,
> >>
> >> Jonathan
> >>
> >>
> >
Re: Review Request: First cut at a working load balancer
Posted by Ted Yu <yu...@gmail.com>.
Looking at https://issues.apache.org/jira/browse/HBASE-2697, I found another
review request: http://review.hbase.org/r/382/#review476 which is related to
HBASE-2692
I am not sure whether I should comment about load balancing in HBASE-2697
On Sun, Jul 25, 2010 at 1:31 PM, Ted Yu <yu...@gmail.com> wrote:
> Jonathan:
> Can you elaborate on how the following information (input tobalanceCluster)
> is gathered ?
>
> Map<HServerInfo,List<HRegionInfo>> serverInfo
>
> Considering the implication from HBASE-2473, some (pre-created) regions may
> stay empty for some time. Would those regions be included in the above Map ?
>
> Thanks
>
>
> On Wed, Jul 7, 2010 at 4:48 PM, Jonathan Gray <jg...@apache.org> wrote:
>
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://review.hbase.org/r/282/
>> -----------------------------------------------------------
>>
>> Review request for hbase.
>>
>>
>> Summary
>> -------
>>
>> Just putting this up to show people. It's not done but the
>> balanceCluster() method "works" and has a bunch of test cases.
>>
>>
>> This addresses bug HBASE-2697.
>> http://issues.apache.org/jira/browse/HBASE-2697
>>
>>
>> Diffs
>> -----
>>
>> branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/HServerInfo.java
>> 961064
>> branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java
>> PRE-CREATION
>> branches/0.90_master_rewrite/src/test/java/org/apache/hadoop/hbase/master/TestLoadBalancer.java
>> PRE-CREATION
>>
>> Diff: http://review.hbase.org/r/282/diff
>>
>>
>> Testing
>> -------
>>
>> Added TestLoadBalancer.testLoadBalancer_balanceCluster(). If you have any
>> good edge cases let me know!
>>
>>
>> Thanks,
>>
>> Jonathan
>>
>>
>
Re: Review Request: First cut at a working load balancer
Posted by Ted Yu <yu...@gmail.com>.
Jonathan:
Can you elaborate on how the following information (input to balanceCluster)
is gathered ?
Map<HServerInfo,List<HRegionInfo>> serverInfo
Considering the implication from HBASE-2473, some (pre-created) regions may
stay empty for some time. Would those regions be included in the above Map ?
Thanks
On Wed, Jul 7, 2010 at 4:48 PM, Jonathan Gray <jg...@apache.org> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/282/
> -----------------------------------------------------------
>
> Review request for hbase.
>
>
> Summary
> -------
>
> Just putting this up to show people. It's not done but the
> balanceCluster() method "works" and has a bunch of test cases.
>
>
> This addresses bug HBASE-2697.
> http://issues.apache.org/jira/browse/HBASE-2697
>
>
> Diffs
> -----
>
> branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/HServerInfo.java
> 961064
> branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java
> PRE-CREATION
> branches/0.90_master_rewrite/src/test/java/org/apache/hadoop/hbase/master/TestLoadBalancer.java
> PRE-CREATION
>
> Diff: http://review.hbase.org/r/282/diff
>
>
> Testing
> -------
>
> Added TestLoadBalancer.testLoadBalancer_balanceCluster(). If you have any
> good edge cases let me know!
>
>
> Thanks,
>
> Jonathan
>
>