[GitHub] [beam] pabloem commented on pull request #15611: [BEAM-12607] - Copy Code Snippet copies html tags

[GitBox <gi...@apache.org>]

pabloem commented on pull request #15611:
URL: https://github.com/apache/beam/pull/15611#issuecomment-930557151


   Agreed to remove! Thanks.
   
   On Wed, Sep 29, 2021, 11:10 AM Alexey Romanenko ***@***.***>
   wrote:
   
   > ***@***.**** commented on this pull request.
   > ------------------------------
   >
   > In website/www/site/static/js/copy-to-clipboard.js
   > <https://github.com/apache/beam/pull/15611#discussion_r718724103>:
   >
   > > @@ -13,15 +13,15 @@
   >  $(document).ready(function() {
   >      function copy() {
   >          $(".copy").click(function(){
   > -            var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerHTML;
   > +            var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerText;
   >              const el=document.createElement('textarea');
   >              el.value=text;document.body.appendChild(el);
   >              el.select();document.execCommand('copy');
   >              document.body.removeChild(el);
   >              alert('copied to clipboard');
   >
   > +1 to remove it. @pabloem <https://github.com/pabloem>, wdyt?
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/beam/pull/15611#discussion_r718724103>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAJ5Z3BIZC4KGTDTR4RPJQLUENCAJANCNFSM5E6NB7ZQ>
   > .
   > Triage notifications on the go with GitHub Mobile for iOS
   > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
   > or Android
   > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
   >
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org