You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@toree.apache.org by kervel <gi...@git.apache.org> on 2017/11/15 13:38:14 UTC
[GitHub] incubator-toree pull request #146: Add --exclude option to AddDeps and exclu...
GitHub user kervel opened a pull request:
https://github.com/apache/incubator-toree/pull/146
Add --exclude option to AddDeps and exclude org.scala-lang.modules by default
This PR includes the (in my eyes valid) fix to TOREE-420 by Kalvin Chau, and extends on it by adding a way to work around other dependency conflicts by excluding specific dependencies. This is already possible in other scala-based interactive notebooks.
For example, look at https://zeppelin.apache.org/docs/0.6.2/manual/dependencymanagement.html
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Kapernikov/incubator-toree depExcludes_rebased
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-toree/pull/146.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #146
----
commit db48bf33e867c05b4bb560a3f787153d86c1c393
Author: Kalvin Chau <ka...@viasat.com>
Date: 2017-06-22T20:26:41Z
updated depdency downloaders to exclude org.scala-lang.modules to prevent scala refelection issues TOREE-420
commit 2094e0187543ee111c7ee332d95d613b53a568ef
Author: Frank Dekervel <fr...@infrabel.be>
Date: 2017-09-11T07:58:04Z
Add --exclude option to AddDeps in order to be able to exclude certain modules
The exclude syntax is follows "organisation:name" or "organisation" when everything from a certain organisation is to be excluded
----
---
[GitHub] incubator-toree pull request #146: Add --exclude option to AddDeps and exclu...
Posted by lresende <gi...@git.apache.org>.
Github user lresende commented on a diff in the pull request:
https://github.com/apache/incubator-toree/pull/146#discussion_r161387042
--- Diff: kernel-api/src/main/scala/org/apache/toree/dependencies/CoursierDependencyDownloader.scala ---
@@ -76,15 +76,16 @@ class CoursierDependencyDownloader extends DependencyDownloader {
trace: Boolean,
configuration: Option[String] = None,
artifactType: Option[String] = None,
- artifactClassifier: Option[String] = None
+ artifactClassifier: Option[String] = None,
+ excludes: Set[(String,String)] = Set.empty
--- End diff --
As you are adding a new parameter here, you also need to update the addDepsSpec where it defines a mock of a dependency downloader and add a new parameter to the mock (any[Set[(String,String)]]). I am playing with it and if that's the only thing I might update your pr before merging, otherwise please make sure you look into this.
---
[GitHub] incubator-toree pull request #146: Add --exclude option to AddDeps and exclu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-toree/pull/146
---
[GitHub] incubator-toree pull request #146: Add --exclude option to AddDeps and exclu...
Posted by kervel <gi...@git.apache.org>.
GitHub user kervel reopened a pull request:
https://github.com/apache/incubator-toree/pull/146
Add --exclude option to AddDeps and exclude org.scala-lang.modules by default
This PR includes the (in my eyes valid) fix to TOREE-420 by Kalvin Chau, and extends on it by adding a way to work around other dependency conflicts by excluding specific dependencies. This is already possible in other scala-based interactive notebooks.
For example, look at https://zeppelin.apache.org/docs/0.6.2/manual/dependencymanagement.html
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Kapernikov/incubator-toree depExcludes_rebased
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-toree/pull/146.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #146
----
commit db48bf33e867c05b4bb560a3f787153d86c1c393
Author: Kalvin Chau <ka...@viasat.com>
Date: 2017-06-22T20:26:41Z
updated depdency downloaders to exclude org.scala-lang.modules to prevent scala refelection issues TOREE-420
commit 2094e0187543ee111c7ee332d95d613b53a568ef
Author: Frank Dekervel <fr...@infrabel.be>
Date: 2017-09-11T07:58:04Z
Add --exclude option to AddDeps in order to be able to exclude certain modules
The exclude syntax is follows "organisation:name" or "organisation" when everything from a certain organisation is to be excluded
----
---
[GitHub] incubator-toree pull request #146: Add --exclude option to AddDeps and exclu...
Posted by kervel <gi...@git.apache.org>.
Github user kervel closed the pull request at:
https://github.com/apache/incubator-toree/pull/146
---