You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Padma Priya N <pa...@gmail.com> on 2017/02/15 06:07:25 UTC

Review Request 56696: AMBARI-19978:Coordinator tag sequence is not maintained

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56696/
-----------------------------------------------------------

Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.


Bugs: AMBARI-19978
    https://issues.apache.org/jira/browse/AMBARI-19978


Repository: ambari


Description
-------

Modified the ordering of properties in the coordinator object and modified the xml generation in par with the xsd.


Diffs
-----

  contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 658cbc0 
  contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 39b9d11 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-generator.js cbefa99 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js ddb2b43 

Diff: https://reviews.apache.org/r/56696/diff/


Testing
-------

Manual Testing


Thanks,

Padma Priya N


Re: Review Request 56696: AMBARI-19978:Coordinator tag sequence is not maintained

Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56696/#review165668
-----------------------------------------------------------


Ship it!




Ship It!

- belliraj hb


On Feb. 15, 2017, 6:07 a.m., Padma Priya N wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56696/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2017, 6:07 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19978
>     https://issues.apache.org/jira/browse/AMBARI-19978
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Modified the ordering of properties in the coordinator object and modified the xml generation in par with the xsd.
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 658cbc0 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 39b9d11 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-generator.js cbefa99 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js ddb2b43 
> 
> Diff: https://reviews.apache.org/r/56696/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>


Re: Review Request 56696: AMBARI-19978:Coordinator tag sequence is not maintained

Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56696/#review165673
-----------------------------------------------------------


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 15, 2017, 6:07 a.m., Padma Priya N wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56696/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2017, 6:07 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19978
>     https://issues.apache.org/jira/browse/AMBARI-19978
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Modified the ordering of properties in the coordinator object and modified the xml generation in par with the xsd.
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 658cbc0 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 39b9d11 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-generator.js cbefa99 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js ddb2b43 
> 
> Diff: https://reviews.apache.org/r/56696/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>