You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2007/12/14 01:30:17 UTC
svn commit: r604072 - in /jakarta/jmeter/trunk:
src/core/org/apache/jmeter/engine/RemoteJMeterEngineImpl.java
xdocs/changes.xml
Author: sebb
Date: Thu Dec 13 16:30:16 2007
New Revision: 604072
URL: http://svn.apache.org/viewvc?rev=604072&view=rev
Log:
Bug 41028 - JMeter server doesn't alert the user when the host is defined as a loopback address
Modified:
jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/RemoteJMeterEngineImpl.java
jakarta/jmeter/trunk/xdocs/changes.xml
Modified: jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/RemoteJMeterEngineImpl.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/RemoteJMeterEngineImpl.java?rev=604072&r1=604071&r2=604072&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/RemoteJMeterEngineImpl.java (original)
+++ jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/RemoteJMeterEngineImpl.java Thu Dec 13 16:30:16 2007
@@ -19,6 +19,7 @@
package org.apache.jmeter.engine;
import java.net.InetAddress;
+import java.net.UnknownHostException;
import java.rmi.RemoteException;
import java.rmi.registry.LocateRegistry;
import java.rmi.registry.Registry;
@@ -57,6 +58,17 @@
private void init(int port) throws RemoteException {
log.info("Starting backing engine on " + port);
+ InetAddress localHost=null;
+ try {
+ localHost = InetAddress.getLocalHost();
+ } catch (UnknownHostException e1) {
+ throw new RemoteException("Cannot start. Unable to get local host IP address.");
+ }
+ log.info("IP address="+localHost.getHostAddress());
+ hostName = localHost.getHostName();
+ if (localHost.isLoopbackAddress()){
+ throw new RemoteException("Cannot start. "+hostName+" is a loopback address.");
+ }
log.debug("This = " + this);
if (createServer){
log.info("Creating RMI registry (server.rmi.create=true)");
@@ -71,7 +83,6 @@
}
try {
Registry reg = LocateRegistry.getRegistry(port);
- hostName = InetAddress.getLocalHost().getHostName();
log.info("Creating JMeter engine on host "+hostName);
backingEngine = new StandardJMeterEngine(hostName);// see setHost()
reg.rebind("JMeterEngine", this); // $NON-NLS-1$
Modified: jakarta/jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/xdocs/changes.xml?rev=604072&r1=604071&r2=604072&view=diff
==============================================================================
--- jakarta/jmeter/trunk/xdocs/changes.xml (original)
+++ jakarta/jmeter/trunk/xdocs/changes.xml Thu Dec 13 16:30:16 2007
@@ -67,6 +67,7 @@
<li>Bug 33954 - Stack Overflow in If/While controllers (may have been fixed previously)</li>
<li>Bug 44022 - Memory Leak when closing test plan</li>
<li>Bug 44042 - Regression in Cookie Manager (Bug introduced in 2.3.1)</li>
+<li>Bug 41028 - JMeter server doesn't alert the user when the host is defined as a loopback address</li>
</ul>
<h4>Improvements</h4>
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org