[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #974: [KYUUBI #962] Support multiple engines under USER share level

[GitBox <gi...@apache.org>]

yaooqinn commented on a change in pull request #974:
URL: https://github.com/apache/incubator-kyuubi/pull/974#discussion_r693633499



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/engine/EngineRef.scala
##########
@@ -126,11 +130,33 @@ private[kyuubi] class EngineRef private(conf: KyuubiConf, user: String, sessionI
   }
 
   private def create(zkClient: CuratorFramework): (String, Int) = tryWithLock(zkClient) {
-    // TODO: improve this after support engine pool. (KYUUBI #918)
-    var engineRef = getServerHost(zkClient, engineSpace)
-    // Get the engine address ahead if another process has succeeded
-    if (engineRef.nonEmpty) return engineRef.get
 
+    // USER share level support engine pool
+    if (shareLevel.equals(USER)) {
+
+      // create engine space
+      createEngineSpaceIfNotExists(zkClient, engineSpace, conf.get(HA_ZK_ENGINE_POOL_SIZE))
+
+      // create engine if not reach pool size

Review comment:
       How can we reach to pool size？




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org