You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Marton Greber (Code Review)" <ge...@cloudera.org> on 2026/02/09 17:46:05 UTC

[kudu-CR] Remove the replace flag if the move fails in auto rebalancing.

Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21073 )

Change subject: Remove the replace flag if the move fails in auto rebalancing.
......................................................................


Patch Set 16: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21073/16/src/kudu/master/auto_rebalancer.cc
File src/kudu/master/auto_rebalancer.cc:

http://gerrit.cloudera.org:8080/#/c/21073/16/src/kudu/master/auto_rebalancer.cc@746
PS16, Line 746: rpc
Shouldn't this rpc controller have a timeout set? 
I've checked, all other rpc controllers in this file and all use this value:
rpc.set_timeout(MonoDelta::FromSeconds(FLAGS_auto_rebalancing_rpc_timeout_seconds));



-- 
To view, visit http://gerrit.cloudera.org:8080/21073
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99dafa654878b9d6d8162d84500913ae0655692b
Gerrit-Change-Number: 21073
Gerrit-PatchSet: 16
Gerrit-Owner: Song Jiacheng <so...@thinkingdata.cn>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Song Jiacheng <so...@thinkingdata.cn>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Comment-Date: Mon, 09 Feb 2026 17:46:05 +0000
Gerrit-HasComments: Yes