You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/02/15 17:26:58 UTC
[GitHub] [maven-compiler-plugin] dbwiddis opened a new pull request #95: [MCOMPILER-485] Fixes internal string format in generated package-info.class
dbwiddis opened a new pull request #95:
URL: https://github.com/apache/maven-compiler-plugin/pull/95
Per JLS 4.2.1, the package name representation in the internal class structure always contains forward slashes in place of periods. This PR fixes the code from MCOMPILER-205 which passed a package name extracted from the file path which used backward slashes on Windows.
The IT is copied from MCOMPILER-205 but with a more detailed test to confirm the correct internal representation of the package name in the class file.
I was unable to successfully run `mvn -Prun-its clean verify` due to some unrelated error in generate-helpmojo that existed before my changes. I have run `mvn clean verify` successfully.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCOMPILER) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MCOMPILER-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] dbwiddis commented on pull request #95: [MCOMPILER-485] Fixes internal string format in generated package-info.class
Posted by GitBox <gi...@apache.org>.
dbwiddis commented on pull request #95:
URL: https://github.com/apache/maven-compiler-plugin/pull/95#issuecomment-1040746366
Sorry for the force-push churn. Finally got IT tests to work and had a upper/lower case issue in the hex string, then forgot to use fixup on the rebase. Should be good to go now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] olamy merged pull request #95: [MCOMPILER-485] Fixes internal string format in generated package-info.class
Posted by GitBox <gi...@apache.org>.
olamy merged pull request #95:
URL: https://github.com/apache/maven-compiler-plugin/pull/95
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] olamy commented on pull request #95: [MCOMPILER-485] Fixes internal string format in generated package-info.class
Posted by GitBox <gi...@apache.org>.
olamy commented on pull request #95:
URL: https://github.com/apache/maven-compiler-plugin/pull/95#issuecomment-1040801816
> Sorry for the force-push churn. Finally got IT tests to work and had a upper/lower case issue in the hex string, then forgot to use fixup on the rebase. Should be good to go now.
no worries mate. Thanks again for your help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org