[jira] [Commented] (LUCENE-9032) Make public: BaseTokenStreamTestCase.checkResetException

["David Smiley (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-9032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962336#comment-16962336 ] 

David Smiley commented on LUCENE-9032:
--------------------------------------

Alternatively, perhaps checkAnalysisConsistency should call checkResetException first?  

I noticed exactly one of the many assertAnalyzesTo overloaded variants does _not_ call checkAnalysisConsistency which is suspicious.  This unusual cases was introduced by [~sarowe] in LUCENE-2899.  I added it to be consistent and the OpenNLP tests that call it work with this extra checking.  Thoughts?

> Make public: BaseTokenStreamTestCase.checkResetException
> --------------------------------------------------------
>
>                 Key: LUCENE-9032
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9032
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/test-framework
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>
> Ideally {{BaseTokenStreamTestCase.checkResetException}} would be public so that 3rd party projects can test this.  assertTokenStreamContents is public, checkAnalysisConsistency is public, assertAnalyzesTo is public.  It's currently possible to _indirectly_ get this check because assertAnalyzesTo will call it, but this forces the use of RandomizedTesting and 3rd parties might not be using that.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org