You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bridges-dev@portals.apache.org by "Thomas Spiegl (JIRA)" <br...@portals.apache.org> on 2007/06/12 00:31:25 UTC

[jira] Created: (PB-66) FacesPortlet should apply defaultRenderKitId instead of HTML_BASIC

FacesPortlet should apply defaultRenderKitId instead of HTML_BASIC
------------------------------------------------------------------

                 Key: PB-66
                 URL: https://issues.apache.org/jira/browse/PB-66
             Project: Portals Bridges
          Issue Type: Bug
          Components: jsf
    Affects Versions: 1.0.2-RC
            Reporter: Thomas Spiegl
         Attachments: FacesPortlet.patch

FacesPortlet should set the defaultRenderKitId instead of HTML_BASIC
This bug leads to a general incompatibility with other Renderkits. 
MyFaces Trinidad for example has a renderkit other than HTML_BASIC and does not work with 1.0.2-RC.

attached the patch.

Thomas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org


[jira] Commented: (PB-66) FacesPortlet should apply defaultRenderKitId instead of HTML_BASIC

Posted by "Matthew Bruzek (JIRA)" <br...@portals.apache.org>.
    [ https://issues.apache.org/jira/browse/PB-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512616 ] 

Matthew Bruzek commented on PB-66:
----------------------------------

We are encountering a problem that is related to this change.  Our JSF application was running on the previous version of the MyFaces portlet bridge.  When I changed the jar files to try the new code out we got the following exception:

	javax.servlet.ServletException: Argument Error: One or more parameters are null. renderKitId null
	at org.apache.jasper.runtime.PageContextImpl.handlePageException(PageContextImpl.java:658)
	at _ibmjsp.com.ibm.usmi.console.core.jsps._NavigatorWidgetPage._jspService(_NavigatorWidgetPage.java:104)
	at com.ibm.ws.jsp.runtime.HttpJspBase.service(HttpJspBase.java:85)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:810)
...
Caused by: java.lang.NullPointerException: Argument Error: One or more parameters are null. renderKitId null
	at com.sun.faces.renderkit.RenderKitFactoryImpl.getRenderKit(RenderKitFactoryImpl.java:74)
	at com.ibm.faces.renderkit.AjaxRenderKitFactory.getRenderKit(AjaxRenderKitFactory.java:73)
	at javax.faces.webapp.UIComponentTag.setupResponseWriter(UIComponentTag.java:918)
	at javax.faces.webapp.UIComponentTag.doStartTag(UIComponentTag.java:418)
	at com.sun.faces.taglib.jsf_core.ViewTag.doStartTag(ViewTag.java:104)
	at _ibmjsp.com.ibm.usmi.console.core.jsps._NavigatorWidgetPage._jspx_meth_f_view_0(_NavigatorWidgetPage.java:218)
	at _ibmjsp.com.ibm.usmi.console.core.jsps._NavigatorWidgetPage._jspService(_NavigatorWidgetPage.java:96)
	at com.ibm.ws.jsp.runtime.HttpJspBase.service(HttpJspBase.java:85)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:810)

We define many custom renderers but do not have the default-render-kit-id tag in our faces config file.  Our code was working before and this change seems to break a working case.

Can we compromise and change the code to get the default render kit id and if it is null, set it to RenderKitFactory.HTML_BASIC_RENDER_KIT?



> FacesPortlet should apply defaultRenderKitId instead of HTML_BASIC
> ------------------------------------------------------------------
>
>                 Key: PB-66
>                 URL: https://issues.apache.org/jira/browse/PB-66
>             Project: Portals Bridges
>          Issue Type: Bug
>          Components: jsf
>    Affects Versions: 1.0.2-RC
>            Reporter: Thomas Spiegl
>            Assignee: Ate Douma
>             Fix For: 1.0.3
>
>         Attachments: FacesPortlet.patch
>
>
> FacesPortlet should set the defaultRenderKitId instead of HTML_BASIC
> This bug leads to a general incompatibility with other Renderkits. 
> MyFaces Trinidad for example has a renderkit other than HTML_BASIC and does not work with 1.0.2-RC.
> attached the patch.
> Thomas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org


[jira] Assigned: (PB-66) FacesPortlet should apply defaultRenderKitId instead of HTML_BASIC

Posted by "Ate Douma (JIRA)" <br...@portals.apache.org>.
     [ https://issues.apache.org/jira/browse/PB-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ate Douma reassigned PB-66:
---------------------------

    Assignee: Ate Douma

> FacesPortlet should apply defaultRenderKitId instead of HTML_BASIC
> ------------------------------------------------------------------
>
>                 Key: PB-66
>                 URL: https://issues.apache.org/jira/browse/PB-66
>             Project: Portals Bridges
>          Issue Type: Bug
>          Components: jsf
>    Affects Versions: 1.0.2-RC
>            Reporter: Thomas Spiegl
>            Assignee: Ate Douma
>         Attachments: FacesPortlet.patch
>
>
> FacesPortlet should set the defaultRenderKitId instead of HTML_BASIC
> This bug leads to a general incompatibility with other Renderkits. 
> MyFaces Trinidad for example has a renderkit other than HTML_BASIC and does not work with 1.0.2-RC.
> attached the patch.
> Thomas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org


[jira] Resolved: (PB-66) FacesPortlet should apply defaultRenderKitId instead of HTML_BASIC

Posted by "Ate Douma (JIRA)" <br...@portals.apache.org>.
     [ https://issues.apache.org/jira/browse/PB-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ate Douma resolved PB-66.
-------------------------

       Resolution: Fixed
    Fix Version/s: 1.0.2

Patch applied, thanks

> FacesPortlet should apply defaultRenderKitId instead of HTML_BASIC
> ------------------------------------------------------------------
>
>                 Key: PB-66
>                 URL: https://issues.apache.org/jira/browse/PB-66
>             Project: Portals Bridges
>          Issue Type: Bug
>          Components: jsf
>    Affects Versions: 1.0.2-RC
>            Reporter: Thomas Spiegl
>            Assignee: Ate Douma
>             Fix For: 1.0.2
>
>         Attachments: FacesPortlet.patch
>
>
> FacesPortlet should set the defaultRenderKitId instead of HTML_BASIC
> This bug leads to a general incompatibility with other Renderkits. 
> MyFaces Trinidad for example has a renderkit other than HTML_BASIC and does not work with 1.0.2-RC.
> attached the patch.
> Thomas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org


[jira] Updated: (PB-66) FacesPortlet should apply defaultRenderKitId instead of HTML_BASIC

Posted by "Thomas Spiegl (JIRA)" <br...@portals.apache.org>.
     [ https://issues.apache.org/jira/browse/PB-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Spiegl updated PB-66:
----------------------------

    Attachment: FacesPortlet.patch

Patch

> FacesPortlet should apply defaultRenderKitId instead of HTML_BASIC
> ------------------------------------------------------------------
>
>                 Key: PB-66
>                 URL: https://issues.apache.org/jira/browse/PB-66
>             Project: Portals Bridges
>          Issue Type: Bug
>          Components: jsf
>    Affects Versions: 1.0.2-RC
>            Reporter: Thomas Spiegl
>         Attachments: FacesPortlet.patch
>
>
> FacesPortlet should set the defaultRenderKitId instead of HTML_BASIC
> This bug leads to a general incompatibility with other Renderkits. 
> MyFaces Trinidad for example has a renderkit other than HTML_BASIC and does not work with 1.0.2-RC.
> attached the patch.
> Thomas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org


[jira] Commented: (PB-66) FacesPortlet should apply defaultRenderKitId instead of HTML_BASIC

Posted by "Ate Douma (JIRA)" <br...@portals.apache.org>.
    [ https://issues.apache.org/jira/browse/PB-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512750 ] 

Ate Douma commented on PB-66:
-----------------------------

I agree we should do that, although you can already easily prevent this problem by defining the default-render-kit-id in faces-config.
I created new (minor) issue PB-71 to address this, which I will handle after 1.0.3 is released.

> FacesPortlet should apply defaultRenderKitId instead of HTML_BASIC
> ------------------------------------------------------------------
>
>                 Key: PB-66
>                 URL: https://issues.apache.org/jira/browse/PB-66
>             Project: Portals Bridges
>          Issue Type: Bug
>          Components: jsf
>    Affects Versions: 1.0.2-RC
>            Reporter: Thomas Spiegl
>            Assignee: Ate Douma
>             Fix For: 1.0.3
>
>         Attachments: FacesPortlet.patch
>
>
> FacesPortlet should set the defaultRenderKitId instead of HTML_BASIC
> This bug leads to a general incompatibility with other Renderkits. 
> MyFaces Trinidad for example has a renderkit other than HTML_BASIC and does not work with 1.0.2-RC.
> attached the patch.
> Thomas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org