You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by milamberspace <gi...@git.apache.org> on 2016/11/27 11:34:55 UTC

[GitHub] cloudstack pull request #1791: CLOUDSTACK-9622 Localisation for 'Project' la...

GitHub user milamberspace opened a pull request:

    https://github.com/apache/cloudstack/pull/1791

    CLOUDSTACK-9622 Localisation for 'Project' label on the top of Web UI

    [Base 4.9, forward to 4.10 too]
    
    The label Project isn't localized.
    
    Sample with chinese UI:
    Current:
    ![selection_457](https://cloud.githubusercontent.com/assets/3995882/20648086/56e54cfe-b495-11e6-9e78-3590a24302d1.png)
    
    With this PR:
    ![selection_456](https://cloud.githubusercontent.com/assets/3995882/20648088/6090960a-b495-11e6-9dc0-eb24e16dcdc6.png)
    
    cc @rhtyd 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/milamberspace/cloudstack CLOUDSTACK-9622_Fix_Project_Not_L10N

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1791.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1791
    
----
commit 0522d0df934e9dea13315735ef5f111ec610b510
Author: Milamber <mi...@apache.org>
Date:   2016-11-27T10:47:25Z

    CLOUDSTACK-9622 Localisation for 'Project' label on the top of Web UI

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1791: CLOUDSTACK-9622 Localisation for 'Project' label on ...

Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:

    https://github.com/apache/cloudstack/pull/1791
  
    LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1791: CLOUDSTACK-9622 Localisation for 'Project' la...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/1791


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1791: CLOUDSTACK-9622 Localisation for 'Project' label on ...

Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:

    https://github.com/apache/cloudstack/pull/1791
  
    LGTM, tested manually similar changes as seen in screenshots from @milamberspace 
    I'll proceed with merging this now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---