You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/05 07:17:14 UTC
[GitHub] [arrow-datafusion] houqp opened a new pull request #678: dedup using join column in wildcard expansion
houqp opened a new pull request #678:
URL: https://github.com/apache/arrow-datafusion/pull/678
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Follow up for https://github.com/apache/arrow-datafusion/pull/605.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Duduplicate using join columns in wildcard projection.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
Using join wildcard projection now only projects a single join column from one side of the join clause.
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on a change in pull request #678: dedup using join column in wildcard expansion
Posted by GitBox <gi...@apache.org>.
houqp commented on a change in pull request #678:
URL: https://github.com/apache/arrow-datafusion/pull/678#discussion_r668466479
##########
File path: datafusion/src/logical_plan/builder.rs
##########
@@ -220,10 +223,33 @@ impl LogicalPlanBuilder {
for e in expr {
Review comment:
refactored the code to use the same expand_wildcard implementation in both places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #678: dedup using join column in wildcard expansion
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #678:
URL: https://github.com/apache/arrow-datafusion/pull/678#issuecomment-879102722
I think it is looking great -- thanks @houqp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a change in pull request #678: dedup using join column in wildcard expansion
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #678:
URL: https://github.com/apache/arrow-datafusion/pull/678#discussion_r668210285
##########
File path: datafusion/src/logical_plan/builder.rs
##########
@@ -220,10 +223,33 @@ impl LogicalPlanBuilder {
for e in expr {
Review comment:
I wonder if you could call `expand_wildcard` directly from here rather than duplicating the logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #678: dedup using join column in wildcard expansion
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #678:
URL: https://github.com/apache/arrow-datafusion/pull/678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on a change in pull request #678: dedup using join column in wildcard expansion
Posted by GitBox <gi...@apache.org>.
houqp commented on a change in pull request #678:
URL: https://github.com/apache/arrow-datafusion/pull/678#discussion_r668466479
##########
File path: datafusion/src/logical_plan/builder.rs
##########
@@ -220,10 +223,33 @@ impl LogicalPlanBuilder {
for e in expr {
Review comment:
refactored the code to use same expand_wildcard implementation in both places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org