You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/03/02 17:05:14 UTC

[GitHub] david-streamlio commented on a change in pull request #3678: [Pulsar Functions] Add support for multiple sinks/sources in a single NAR file.

david-streamlio commented on a change in pull request #3678: [Pulsar Functions] Add support for multiple sinks/sources in a single NAR file.
URL: https://github.com/apache/pulsar/pull/3678#discussion_r261833878
 
 

 ##########
 File path: pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SinkConfigUtils.java
 ##########
 @@ -297,7 +299,21 @@ public static ExtractedSinkDetails validate(SinkConfig sinkConfig, Path archiveP
         if (!isEmpty(sinkConfig.getClassName())) {
             sinkClassName = sinkConfig.getClassName();
             try {
-                classLoader = Utils.extractClassLoader(archivePath, functionPkgUrl, uploadedInputStreamAsFile);
+                String ext = null;
+            	if (!isEmpty(functionPkgUrl)) {
+            		File file = Utils.extractFileFromPkg(functionPkgUrl);
 
 Review comment:
   Fixed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services