You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/12/06 03:47:47 UTC

[GitHub] [fineract] IOhacker opened a new pull request #1995: Disabling SonarQube HotSpot

IOhacker opened a new pull request #1995:
URL: https://github.com/apache/fineract/pull/1995


   Disabling SonarQube HotSpot because Fineract API Rest is creating services that are used by non-browser clients as per Spring Documentation
   
   https://docs.spring.io/spring-security/site/docs/5.2.12.RELEASE/reference/html/features.html#csrf-when
   
   ## Description
   
   Disabling SonarQube HotSpot because Fineract API Rest is creating services that are used by non-browser clients
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [X] Write the commit message as per https://github.com/apache/fineract/#pull-requests
   
   - [X] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
   
   - [X] Create/update unit or integration tests for verifying the changes made.
   
   - [X] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   
   - [X] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
   
   - [X] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)
   
   FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola commented on pull request #1995: Disabling SonarQube HotSpot

Posted by GitBox <gi...@apache.org>.

ptuomola commented on pull request #1995:
URL: https://github.com/apache/fineract/pull/1995#issuecomment-986519544


   @IOhacker spotless didn't like the formatting... Can you check? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola merged pull request #1995: Disabling SonarQube HotSpot

Posted by GitBox <gi...@apache.org>.

ptuomola merged pull request #1995:
URL: https://github.com/apache/fineract/pull/1995


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] IOhacker commented on pull request #1995: Disabling SonarQube HotSpot

Posted by GitBox <gi...@apache.org>.

IOhacker commented on pull request #1995:
URL: https://github.com/apache/fineract/pull/1995#issuecomment-986824963


   Hello, I have just fixed the formatting issue.
   
   El lun, 6 dic 2021 a las 1:51, Petri Tuomola ***@***.***>)
   escribió:
   
   > @IOhacker <https://github.com/IOhacker> spotless didn't like the
   > formatting... Can you check?
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/fineract/pull/1995#issuecomment-986519544>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/ALD2ZATGTT2H32OKEYS25TTUPRTPJANCNFSM5JNUEVEQ>
   > .
   > Triage notifications on the go with GitHub Mobile for iOS
   > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
   > or Android
   > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
   >
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org