You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Harsh J (Created) (JIRA)" <ji...@apache.org> on 2012/03/13 11:45:43 UTC
[jira] [Created] (OOZIE-759) EmailActionExecutor does not use a
default from-address as documented
EmailActionExecutor does not use a default from-address as documented
---------------------------------------------------------------------
Key: OOZIE-759
URL: https://issues.apache.org/jira/browse/OOZIE-759
Project: Oozie
Issue Type: Bug
Components: action
Affects Versions: 3.2.0
Reporter: Harsh J
Assignee: Harsh J
Priority: Minor
Oozie's docs have: {quote}=oozie.email.from.address= - The from address to be used for mailing all emails (oozie@localhost by default). {quote}
(From http://incubator.apache.org/oozie/docs/3.1.3/docs/DG_EmailActionExtension.html)
However, the code does not seem to use a default when loading the prop from the Oozie conf. Thus if someone does not specify it, it causes an NPE when it tries to from a fromAddress object later.
Same applies to:
{quote}oozie.email.smtp.host - The host where the email action may find the SMTP server (localhost by default). {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-759) EmailActionExecutor does not use a
default from-address as documented
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274404#comment-13274404 ]
Harsh J commented on OOZIE-759:
-------------------------------
For the patch committed in trunk with this JIRA ID (also available under the same JIRA ID in Apache ReviewBoard system), I grant license to ASF for inclusion in ASF works (as per the Apache License ยง5).
> EmailActionExecutor does not use a default from-address as documented
> ---------------------------------------------------------------------
>
> Key: OOZIE-759
> URL: https://issues.apache.org/jira/browse/OOZIE-759
> Project: Oozie
> Issue Type: Bug
> Components: action
> Affects Versions: 3.2.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Labels: email
> Fix For: 3.2.0
>
>
> Oozie's docs have: {quote}=oozie.email.from.address= - The from address to be used for mailing all emails (oozie@localhost by default). {quote}
> (From http://incubator.apache.org/oozie/docs/3.1.3/docs/DG_EmailActionExtension.html)
> However, the code does not seem to use a default when loading the prop from the Oozie conf. Thus if someone does not specify it, it causes an NPE when it tries to from a fromAddress object later.
> Same applies to:
> {quote}oozie.email.smtp.host - The host where the email action may find the SMTP server (localhost by default). {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-759) EmailActionExecutor does not use a
default from-address as documented
Posted by "Harsh J (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228314#comment-13228314 ]
Harsh J commented on OOZIE-759:
-------------------------------
Patch at https://reviews.apache.org/r/4306/
Passes tests:
Running org.apache.oozie.action.email.TestEmailActionExecutor
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.337 sec
> EmailActionExecutor does not use a default from-address as documented
> ---------------------------------------------------------------------
>
> Key: OOZIE-759
> URL: https://issues.apache.org/jira/browse/OOZIE-759
> Project: Oozie
> Issue Type: Bug
> Components: action
> Affects Versions: 3.2.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Labels: email
>
> Oozie's docs have: {quote}=oozie.email.from.address= - The from address to be used for mailing all emails (oozie@localhost by default). {quote}
> (From http://incubator.apache.org/oozie/docs/3.1.3/docs/DG_EmailActionExtension.html)
> However, the code does not seem to use a default when loading the prop from the Oozie conf. Thus if someone does not specify it, it causes an NPE when it tries to from a fromAddress object later.
> Same applies to:
> {quote}oozie.email.smtp.host - The host where the email action may find the SMTP server (localhost by default). {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-759) EmailActionExecutor does not use a
default from-address as documented
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228834#comment-13228834 ]
jiraposter@reviews.apache.org commented on OOZIE-759:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4306/#review5913
-----------------------------------------------------------
Ship it!
+1
- Angelo K.
On 2012-03-13 11:11:02, Harsh J wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4306/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-13 11:11:02)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Oozie's docs have:
bq.
bq. {quote}=oozie.email.from.address= - The from address to be used for mailing all emails (oozie@localhost by default). {quote}
bq.
bq. (From http://incubator.apache.org/oozie/docs/3.1.3/docs/DG_EmailActionExtension.html)
bq.
bq. However, the code does not seem to use a default when loading the prop from the Oozie conf. Thus if someone does not specify it, it causes an NPE when it tries to from a fromAddress object later.
bq.
bq. Same applies to:
bq. {quote}oozie.email.smtp.host - The host where the email action may find the SMTP server (localhost by default). {quote}
bq.
bq.
bq. This addresses bug OOZIE-759.
bq. https://issues.apache.org/jira/browse/OOZIE-759
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 1300071
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java 1300071
bq.
bq. Diff: https://reviews.apache.org/r/4306/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Modified test case to do mix of default loading and config setting. No behavior changed, existing test too passes with patch.
bq.
bq.
bq. Thanks,
bq.
bq. Harsh
bq.
bq.
> EmailActionExecutor does not use a default from-address as documented
> ---------------------------------------------------------------------
>
> Key: OOZIE-759
> URL: https://issues.apache.org/jira/browse/OOZIE-759
> Project: Oozie
> Issue Type: Bug
> Components: action
> Affects Versions: 3.2.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Labels: email
>
> Oozie's docs have: {quote}=oozie.email.from.address= - The from address to be used for mailing all emails (oozie@localhost by default). {quote}
> (From http://incubator.apache.org/oozie/docs/3.1.3/docs/DG_EmailActionExtension.html)
> However, the code does not seem to use a default when loading the prop from the Oozie conf. Thus if someone does not specify it, it causes an NPE when it tries to from a fromAddress object later.
> Same applies to:
> {quote}oozie.email.smtp.host - The host where the email action may find the SMTP server (localhost by default). {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-759) EmailActionExecutor does not use a
default from-address as documented
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228313#comment-13228313 ]
jiraposter@reviews.apache.org commented on OOZIE-759:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4306/
-----------------------------------------------------------
Review request for oozie.
Summary
-------
Oozie's docs have:
{quote}=oozie.email.from.address= - The from address to be used for mailing all emails (oozie@localhost by default). {quote}
(From http://incubator.apache.org/oozie/docs/3.1.3/docs/DG_EmailActionExtension.html)
However, the code does not seem to use a default when loading the prop from the Oozie conf. Thus if someone does not specify it, it causes an NPE when it tries to from a fromAddress object later.
Same applies to:
{quote}oozie.email.smtp.host - The host where the email action may find the SMTP server (localhost by default). {quote}
This addresses bug OOZIE-759.
https://issues.apache.org/jira/browse/OOZIE-759
Diffs
-----
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 1300071
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java 1300071
Diff: https://reviews.apache.org/r/4306/diff
Testing
-------
Modified test case to do mix of default loading and config setting. No behavior changed, existing test too passes with patch.
Thanks,
Harsh
> EmailActionExecutor does not use a default from-address as documented
> ---------------------------------------------------------------------
>
> Key: OOZIE-759
> URL: https://issues.apache.org/jira/browse/OOZIE-759
> Project: Oozie
> Issue Type: Bug
> Components: action
> Affects Versions: 3.2.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Labels: email
>
> Oozie's docs have: {quote}=oozie.email.from.address= - The from address to be used for mailing all emails (oozie@localhost by default). {quote}
> (From http://incubator.apache.org/oozie/docs/3.1.3/docs/DG_EmailActionExtension.html)
> However, the code does not seem to use a default when loading the prop from the Oozie conf. Thus if someone does not specify it, it causes an NPE when it tries to from a fromAddress object later.
> Same applies to:
> {quote}oozie.email.smtp.host - The host where the email action may find the SMTP server (localhost by default). {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira