You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2015/08/17 22:16:04 UTC
Review Request 37549: Add jenkins script to run docker tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37549/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Add jenkins script to run docker tests.
Diffs
-----
support/docker_tests_jenkins_build.sh PRE-CREATION
Diff: https://reviews.apache.org/r/37549/diff/
Testing
-------
./support/docker_jenkins_build_test.sh in ubuntu 14.04
Thanks,
Timothy Chen
Re: Review Request 37549: Add jenkins script to run docker tests.
Posted by Timothy Chen <tn...@apache.org>.
> On Aug. 17, 2015, 9:33 p.m., Vinod Kone wrote:
> > 2 high level comments.
> >
> > Why did you write a whole new script instead of making the current jenkins_build.sh work? This is 90% duplicated code which makes me sad.
> >
> > Also, we shouldn't really depend on non-ASF hosted code (mesosphere's wrapdocker) here. Can that script be committed to this repo?
Hi Vinod,
I just talked to Artem and I'm actually going to follow what he has done around mesos-build-images and build a specific image for docker unit tests so that we can simply just reuse the same build_jenkins_tests script but with a new docker image.
And this new image is basically just includes the wrapdocker (which comes from Docker's dind image, allows us to run docker in docker) and set GTEST_FILTER=*DOCKER*.
Hopefully this makes you happy :)
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37549/#review95648
-----------------------------------------------------------
On Aug. 17, 2015, 8:16 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37549/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2015, 8:16 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add jenkins script to run docker tests.
>
>
> Diffs
> -----
>
> support/docker_tests_jenkins_build.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37549/diff/
>
>
> Testing
> -------
>
> ./support/docker_jenkins_build_test.sh in ubuntu 14.04
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 37549: Add jenkins script to run docker tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37549/#review95648
-----------------------------------------------------------
2 high level comments.
Why did you write a whole new script instead of making the current jenkins_build.sh work? This is 90% duplicated code which makes me sad.
Also, we shouldn't really depend on non-ASF hosted code (mesosphere's wrapdocker) here. Can that script be committed to this repo?
- Vinod Kone
On Aug. 17, 2015, 8:16 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37549/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2015, 8:16 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add jenkins script to run docker tests.
>
>
> Diffs
> -----
>
> support/docker_tests_jenkins_build.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37549/diff/
>
>
> Testing
> -------
>
> ./support/docker_jenkins_build_test.sh in ubuntu 14.04
>
>
> Thanks,
>
> Timothy Chen
>
>