[GitHub] [spark] HeartSaVioR edited a comment on pull request #31495: [SPARK-34383][SS] Optimize WAL commit phase via reducing cost of filesystem operations

[GitBox <gi...@apache.org>]

HeartSaVioR edited a comment on pull request #31495:
URL: https://github.com/apache/spark/pull/31495#issuecomment-774583188


   > I wonder what if we purge the offset/commit logs in batches? For example, we can purge logs every minLogEntriesToMaintain batches. This probably reduces more operations on filesystem.
   
   I also considered this (even with asynchronous manner) but didn't address it altogether. While this PR doesn't change anything on end users perspective, the proposal changes the remaining number of log files (based on the interval on purge). Probably better to make it separate and hear voices on making change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org