You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/12/13 19:34:00 UTC

[jira] [Commented] (GEODE-4079) Deprecate Hash Index and Hash Index APIs

    [ https://issues.apache.org/jira/browse/GEODE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289762#comment-16289762 ] 

ASF GitHub Bot commented on GEODE-4079:
---------------------------------------

nabarunnag opened a new pull request #1163: GEODE-4079: Deprecated Hash Index
URL: https://github.com/apache/geode/pull/1163
 
 
   	* Added deprecated tags on HashIndex class
   	* Deprecated createHashIndex calls in QueryService
   	* Deprecated HASH type in IndexType
   	* Added to the help text in gfsh create index mentioning hash index being deprecated since Apache Geode 1.4.0
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Deprecate Hash Index and Hash Index APIs
> ----------------------------------------
>
>                 Key: GEODE-4079
>                 URL: https://issues.apache.org/jira/browse/GEODE-4079
>             Project: Geode
>          Issue Type: Bug
>          Components: docs, querying
>            Reporter: Jason Huynh
>             Fix For: 1.4.0
>
>
> As discussed on the user and dev list, we should deprecate the Hash Index and the corresponding Hash Index APIs.
> The proposal:
> Currently the Hash Index name causes confusion. It is not a traditional hash look up index, but more of memory savings index.  The index does not store index keys in memory and must hash the keys every time.  The index synchronizes on a backing array and when the backing array needs to be expanded, it currently needs to rehash all elements in the array.  This can be very problematic for larger data sets.
> There were improvements made to one of the functional indexes (compact range index) prior to open sourcing.  These improvements helped reduce the memory consumption of that index and makes it very similar sized to a hash index, but the keys still are stored in memory.  Probably close enough to be a replacement for the hash index in most cases.  The read/write performance on it is also faster than the hash index.
> This works includes:
> Deprecating the Hash Index Class
> Deprecating the createHashIndex API's in query Service
> Deprecating the Hash Index type in IndexTypes (if possible)
> Deprecating the gfsh commands to create hash index and hash index types



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)