[jira] [Commented] (THRIFT-4942) Set PHP struct generated field values as private with getters and setters

["Volodymyr Kupriienko (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073939#comment-17073939 ] 

Volodymyr Kupriienko commented on THRIFT-4942:
----------------------------------------------

[~dcelasun] I'm a PHP developer. We use Apache Thrift in our project for internal API of our microservices.

On my opinion structs should have getters and setters instead of public properties to be immutable, because we don't want to change its state after creating.

> Set PHP struct generated field values as private with getters and setters
> -------------------------------------------------------------------------
>
>                 Key: THRIFT-4942
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4942
>             Project: Thrift
>          Issue Type: Improvement
>          Components: PHP - Compiler
>    Affects Versions: 0.12.0
>         Environment: I'm using Ubuntu 18.04, applies to all platforms
>            Reporter: Dedipyaman Das
>            Priority: Minor
>              Labels: Breaking-Change, newbie, pull-request-available
>   Original Estimate: 0.5h
>          Time Spent: 10m
>  Remaining Estimate: 20m
>
> The PHP autogenerated code currently keeps the struct derived class attributes public, and they have to be accessed like: $class->field.
> The java version keeps them private instead and uses getters and setters to access and mutate the data.
> A similar approach would be a better choice for most oop based php coding standards. 
> I've created a working patch, so if I get approval I will create a Pull request for this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)