Re: [GitHub] metron issue #1188: METRON-1769: Script creation of a release candidate

[Michael Miklavcic <mi...@gmail.com>]

Yeah, the Angular upgrade was the other bit that came to mind. Shane's PR
for the Angular upgrade has the necessary +1's, but @nickwallen you had
requested we hold off on that for this release (which I completely agree
with). https://github.com/apache/metron/pull/1096

On Fri, Sep 7, 2018 at 10:24 AM nickwallen <gi...@git.apache.org> wrote:

> Github user nickwallen commented on the issue:
>
>     https://github.com/apache/metron/pull/1188
>
>     > I'm assuming this always pulls HEAD from master to cut the release.
> Do we need or desire any support for cutting a release from a non-HEAD
> commit?
>
>     It would be very useful to continue to merge PRs into master while a
> release is being voted on.
>
>     I had thought that @mattf-horton use to do the releases in such a way
> that this was not a problem, but I could be wrong.
>
>     For example, this morning I merged PR #1174 into master that I don't
> necessarily want in the next release.  I didn't think about the potential
> impact to the release if we have to cut a new RC.  Sorry about that
> @justinleet .
>
>
>
>
>
>
>
>
> ---
>

Re: [GitHub] metron issue #1188: METRON-1769: Script creation of a release candidate

[Michael Miklavcic <mi...@gmail.com>]

Whoops, yeah. Meant for a GitHub thread, not a email thread

On Fri, Sep 7, 2018, 1:19 PM Casey Stella <ce...@gmail.com> wrote:

> Mike, did you mean to reply to this on the dev list or were you aiming to
> make this comment on the PR?  If you were aiming to make this comment on
> the PR, then I think you need to go through github's UI.
>
> On Fri, Sep 7, 2018 at 1:34 PM Michael Miklavcic <
> michael.miklavcic@gmail.com> wrote:
>
> > Yeah, the Angular upgrade was the other bit that came to mind. Shane's PR
> > for the Angular upgrade has the necessary +1's, but @nickwallen you had
> > requested we hold off on that for this release (which I completely agree
> > with). https://github.com/apache/metron/pull/1096
> >
> > On Fri, Sep 7, 2018 at 10:24 AM nickwallen <gi...@git.apache.org> wrote:
> >
> > > Github user nickwallen commented on the issue:
> > >
> > >     https://github.com/apache/metron/pull/1188
> > >
> > >     > I'm assuming this always pulls HEAD from master to cut the
> release.
> > > Do we need or desire any support for cutting a release from a non-HEAD
> > > commit?
> > >
> > >     It would be very useful to continue to merge PRs into master while
> a
> > > release is being voted on.
> > >
> > >     I had thought that @mattf-horton use to do the releases in such a
> way
> > > that this was not a problem, but I could be wrong.
> > >
> > >     For example, this morning I merged PR #1174 into master that I
> don't
> > > necessarily want in the next release.  I didn't think about the
> potential
> > > impact to the release if we have to cut a new RC.  Sorry about that
> > > @justinleet .
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > ---
> > >
> >
>

Re: [GitHub] metron issue #1188: METRON-1769: Script creation of a release candidate

[Casey Stella <ce...@gmail.com>]

Mike, did you mean to reply to this on the dev list or were you aiming to
make this comment on the PR?  If you were aiming to make this comment on
the PR, then I think you need to go through github's UI.

On Fri, Sep 7, 2018 at 1:34 PM Michael Miklavcic <
michael.miklavcic@gmail.com> wrote:

> Yeah, the Angular upgrade was the other bit that came to mind. Shane's PR
> for the Angular upgrade has the necessary +1's, but @nickwallen you had
> requested we hold off on that for this release (which I completely agree
> with). https://github.com/apache/metron/pull/1096
>
> On Fri, Sep 7, 2018 at 10:24 AM nickwallen <gi...@git.apache.org> wrote:
>
> > Github user nickwallen commented on the issue:
> >
> >     https://github.com/apache/metron/pull/1188
> >
> >     > I'm assuming this always pulls HEAD from master to cut the release.
> > Do we need or desire any support for cutting a release from a non-HEAD
> > commit?
> >
> >     It would be very useful to continue to merge PRs into master while a
> > release is being voted on.
> >
> >     I had thought that @mattf-horton use to do the releases in such a way
> > that this was not a problem, but I could be wrong.
> >
> >     For example, this morning I merged PR #1174 into master that I don't
> > necessarily want in the next release.  I didn't think about the potential
> > impact to the release if we have to cut a new RC.  Sorry about that
> > @justinleet .
> >
> >
> >
> >
> >
> >
> >
> >
> > ---
> >
>