You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "vandonr-amz (via GitHub)" <gi...@apache.org> on 2023/06/27 16:49:23 UTC
[GitHub] [airflow] vandonr-amz opened a new pull request, #32186: Re-apply deferrable for `AthenaOperator`
vandonr-amz opened a new pull request, #32186:
URL: https://github.com/apache/airflow/pull/32186
was merged in #32110
and reverted in #32172
because a parameter name changed after the build had been successful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #32186: Add deferrable mode for `AthenaOperator`
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #32186:
URL: https://github.com/apache/airflow/pull/32186#discussion_r1244266130
##########
airflow/providers/amazon/aws/operators/athena.py:
##########
@@ -33,6 +33,9 @@ class AthenaOperator(BaseOperator):
"""
An operator that submits a presto query to athena.
+ Note: if the task is killed while it runs, it'll cancel the athena query that was launched,
Review Comment:
change to `.. note::`
Similar to https://github.com/apache/airflow/blob/9fa75aaf7a391ebf0e6b6949445c060f6de2ceb9/airflow/operators/bash.py#L80
(for some reason it doesn't allow me to suggest changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #32186: Add deferrable mode for `AthenaOperator`
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #32186:
URL: https://github.com/apache/airflow/pull/32186#discussion_r1244266130
##########
airflow/providers/amazon/aws/operators/athena.py:
##########
@@ -33,6 +33,9 @@ class AthenaOperator(BaseOperator):
"""
An operator that submits a presto query to athena.
+ Note: if the task is killed while it runs, it'll cancel the athena query that was launched,
Review Comment:
change to `.. note:`
Similar to https://github.com/apache/airflow/blob/9fa75aaf7a391ebf0e6b6949445c060f6de2ceb9/airflow/operators/bash.py#L80
(for some reason it doesn't allow me to suggest changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #32186: Re-apply deferrable for `AthenaOperator`
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #32186:
URL: https://github.com/apache/airflow/pull/32186#issuecomment-1609907931
Applied "full tests needed" just in case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vandonr-amz commented on pull request #32186: Add deferrable mode for `AthenaOperator`
Posted by "vandonr-amz (via GitHub)" <gi...@apache.org>.
vandonr-amz commented on PR #32186:
URL: https://github.com/apache/airflow/pull/32186#issuecomment-1609957252
just marking as draft quickly so it's not merged now as I need to update the doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #32186: Re-apply deferrable for `AthenaOperator`
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #32186: Re-apply deferrable for `AthenaOperator`
URL: https://github.com/apache/airflow/pull/32186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #32186: Add deferrable mode for `AthenaOperator`
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #32186:
URL: https://github.com/apache/airflow/pull/32186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org