You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "adam-waldenberg (via GitHub)" <gi...@apache.org> on 2023/02/22 11:16:05 UTC
[GitHub] [geronimo-arthur] adam-waldenberg opened a new pull request, #12: OSX Build Fix
adam-waldenberg opened a new pull request, #12:
URL: https://github.com/apache/geronimo-arthur/pull/12
Build failing for various reasons on OS X. This PR introduces some changes to fix builds under OS X.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-arthur] jeanouii commented on pull request #12: OSX Build Fix
Posted by "jeanouii (via GitHub)" <gi...@apache.org>.
jeanouii commented on PR #12:
URL: https://github.com/apache/geronimo-arthur/pull/12#issuecomment-1450078495
Merging and we can do another iteration if you still encouter issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-arthur] rmannibucau commented on pull request #12: OSX Build Fix
Posted by "rmannibucau (via GitHub)" <gi...@apache.org>.
rmannibucau commented on PR #12:
URL: https://github.com/apache/geronimo-arthur/pull/12#issuecomment-1441377076
@adam-waldenberg this is supposed to be handled by https://github.com/apache/geronimo-arthur/blob/a4241db1120e11595833ba339ad8a2610f527ef8/arthur-impl/src/main/java/org/apache/geronimo/arthur/impl/nativeimage/installer/SdkmanGraalVMInstaller.java#L84, happy to get some enhancements since intent is to work OOTB (sadly I don't have a mac handy).
Only small detail I want to keep is any fallback logic to be on linux to keep current behavior but we definitively want osx to work OOTB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-arthur] adam-waldenberg commented on pull request #12: OSX Build Fix
Posted by "adam-waldenberg (via GitHub)" <gi...@apache.org>.
adam-waldenberg commented on PR #12:
URL: https://github.com/apache/geronimo-arthur/pull/12#issuecomment-1452255078
Great.
Yes there is more to do here... We had to jump through hoops and pretty much disable much of what Arthur does oh OSX and Windows to get it to cooperate. I will see if I can take another look once I have some time over.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-arthur] jeanouii merged pull request #12: OSX Build Fix
Posted by "jeanouii (via GitHub)" <gi...@apache.org>.
jeanouii merged PR #12:
URL: https://github.com/apache/geronimo-arthur/pull/12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-arthur] rmannibucau commented on a diff in pull request #12: OSX Build Fix
Posted by "rmannibucau (via GitHub)" <gi...@apache.org>.
rmannibucau commented on code in PR #12:
URL: https://github.com/apache/geronimo-arthur/pull/12#discussion_r1114214084
##########
arthur-maven-plugin/src/main/java/org/apache/geronimo/arthur/maven/mojo/ArthurMojo.java:
##########
@@ -194,8 +195,9 @@ private String buildDownloadUrl(final String graalPlatform) {
final String graalJavaVersion = versionIncludesJavaVersion ?
versionSegments[versionSegments.length - 1].substring(1) :
System.getProperty("java.version", "1.8").startsWith("8") ? "8" : "11";
- final String githubPlatform = graalPlatform.contains("win") ?
- "windows-amd64" : (graalPlatform.contains("linux") ? "linux-amd64" : "darwin-amd64");
+ final String githubPlatform = graalPlatform.toLowerCase(ROOT).contains("win") ?
+ "windows-amd64" : (graalPlatform.toLowerCase(ROOT).contains("linux") ?
Review Comment:
is it an option to reverse the test to fallback on linux (as before) and not on macos?
rest looks perfect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-arthur] jeanouii commented on pull request #12: OSX Build Fix
Posted by "jeanouii (via GitHub)" <gi...@apache.org>.
jeanouii commented on PR #12:
URL: https://github.com/apache/geronimo-arthur/pull/12#issuecomment-1448311559
Hi,
Can you give it a try now, it looks like fixed now. Thanks for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-arthur] adam-waldenberg commented on pull request #12: OSX Build Fix
Posted by "adam-waldenberg (via GitHub)" <gi...@apache.org>.
adam-waldenberg commented on PR #12:
URL: https://github.com/apache/geronimo-arthur/pull/12#issuecomment-1441374056
So a small note... There are actually more things that need to be done under both OSX and Windows to make Arthur work. They both need an intermediate step whete you have to do `gu install native-image`. We solved it by combining Arthur with the download and antrun plugins with some various trickery in order to make it work... At some point it would be nice to see if this could be solved in Arthur completely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org