You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@bahir.apache.org by GitBox <gi...@apache.org> on 2019/03/22 15:39:31 UTC

[GitHub] [bahir-flink] SuXingLee commented on a change in pull request #50: [BAHIR-202] Improve KuduSink throughput by using async FlushMode

SuXingLee commented on a change in pull request #50: [BAHIR-202] Improve KuduSink throughput by using async FlushMode
URL: https://github.com/apache/bahir-flink/pull/50#discussion_r268224745
 
 

 ##########
 File path: flink-connector-kudu/src/main/java/org/apache/flink/streaming/connectors/kudu/connector/KuduConnector.java
 ##########
 @@ -133,8 +136,15 @@ public void close() throws Exception {
 
         if (client == null) return;
         client.close();
+        
+        if (session == null) return;
 
 Review comment:
   thanks for your review, have been fixed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services