[GitHub] [superset] betodealmeida commented on a change in pull request #17360: fix: Change datatype of column type in BaseColumn to allow larger datatype names for complexed columns

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #17360:
URL: https://github.com/apache/superset/pull/17360#discussion_r743865419



##########
File path: superset/datasets/schemas.py
##########
@@ -42,7 +42,7 @@ def validate_python_date_format(value: str) -> None:
 class DatasetColumnsPutSchema(Schema):
     id = fields.Integer()
     column_name = fields.String(required=True, validate=Length(1, 255))
-    type = fields.String(validate=Length(1, 32))
+    type = fields.String(allow_none=True)

Review comment:
       Do we need to allow `None` here? What happens when we update a dataset setting the type to `None`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org