You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2026/03/26 21:23:53 UTC

(commons-codec) branch master updated: [CODEC-336] Base64.Builder.setUrlSafe() Javadoc incorrectly states null is accepted for primitive boolean parameter

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-codec.git


The following commit(s) were added to refs/heads/master by this push:
     new ca52f570 [CODEC-336] Base64.Builder.setUrlSafe() Javadoc incorrectly states null is accepted for primitive boolean parameter
ca52f570 is described below

commit ca52f570255b2e1f4fd6faeb198799169870fb6d
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Mar 26 17:23:47 2026 -0400

    [CODEC-336] Base64.Builder.setUrlSafe() Javadoc incorrectly states null
    is accepted for primitive boolean parameter
---
 src/changes/changes.xml                                   | 1 +
 src/main/java/org/apache/commons/codec/binary/Base64.java | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index ce6e8d66..ff3fb60c 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -48,6 +48,7 @@ The <action> type attribute can be add,update,fix,remove.
       <action type="fix" dev="ggregory" due-to="Shalu Jha, Andrey, Gary Gregory" issue="CODEC-249">Fix Incorrect transform of CH digraph according Metaphone basic rules #423.</action>
       <action type="fix" dev="ggregory" due-to="DRUser123, Shalu Jha, Gary Gregory" issue="CODEC-317">ColognePhonetic can create duplicate consecutive codes in some cases.</action>
       <action type="fix" dev="ggregory" due-to="fancying, Gary Gregory">Add boundary tests for BinaryCodec.fromAscii partial-bit inputs #425.</action>
+      <action type="fix" dev="ggregory" due-to="Partha Paul, Gary Gregory" issue="CODEC-336">Base64.Builder.setUrlSafe(boolean) Javadoc incorrectly states null is accepted for primitive boolean parameter.</action>
       <!-- ADD -->
       <action type="add" dev="ggregory" due-to="Inkeet, Gary Gregory, Wolff Bock von Wuelfingen" issue="CODEC-326">Add Base58 support.</action>
       <action type="add" dev="ggregory" due-to="Gary Gregory">Add BaseNCodecInputStream.AbstracBuilder.setByteArray(byte[]).</action>
diff --git a/src/main/java/org/apache/commons/codec/binary/Base64.java b/src/main/java/org/apache/commons/codec/binary/Base64.java
index 05c411d7..9a35e860 100644
--- a/src/main/java/org/apache/commons/codec/binary/Base64.java
+++ b/src/main/java/org/apache/commons/codec/binary/Base64.java
@@ -157,7 +157,7 @@ public class Base64 extends BaseNCodec {
          * {@code Builder.setDecodeTableFormat(DecodeTableFormat)} method.
          * </p>
          *
-         * @param urlSafe URL-safe encoding policy, null resets to the default.
+         * @param urlSafe URL-safe encoding policy.
          * @return {@code this} instance.
          */
         public Builder setUrlSafe(final boolean urlSafe) {