[GitHub] TaoLv commented on issue #13811: Add erfinv operator for calculating inverse error function

[GitBox <gi...@apache.org>]

TaoLv commented on issue #13811: Add erfinv operator for calculating inverse error function
URL: https://github.com/apache/incubator-mxnet/pull/13811#issuecomment-466022203
 
 
   @rondogency Could you take a look at those warnings introduced by this PR? If possible we need get rid of them.
   
   ```
   src/operator/tensor/./.././contrib/erfinv-inl.h(79): warning: floating-point value does not fit in required integral type
             detected during:
               instantiation of "DType mxnet::op::mshadow_op::erfinv::Map(DType) [with DType=uint8_t]"
   src/operator/tensor/./../mxnet_op.h(479): here
               instantiation of "void mxnet::op::mxnet_op::op_with_req<OP, req>::Map(mxnet::index_t, DType *, const DType *) [with OP=mxnet::op::mshadow_op::erfinv, req=1, DType=uint8_t]"
   src/operator/tensor/./../mxnet_op.h(701): here
               instantiation of "void mxnet::op::mxnet_op::mxnet_generic_kernel<OP,Args...>(int, Args...) [with OP=mxnet::op::mxnet_op::op_with_req<mxnet::op::mshadow_op::erfinv, 1>, Args=<uint8_t *, uint8_t *>]"
   src/operator/tensor/./../mxnet_op.h(721): here
               instantiation of "void mxnet::op::mxnet_op::Kernel<OP, mxnet::gpu>::Launch(mshadow::Stream<mshadow::gpu> *, int, Args...) [with OP=mxnet::op::mxnet_op::op_with_req<mxnet::op::mshadow_op::erfinv, 1>, Args=<uint8_t *, uint8_t *>]"
   src/operator/tensor/./elemwise_unary_op.h(243): here
               instantiation of "void mxnet::op::UnaryOp::Compute<xpu,OP>(const nnvm::NodeAttrs &, const mxnet::OpContext &, const std::vector<mxnet::TBlob, std::allocator<mxnet::TBlob>> &, const std::vector<mxnet::OpReqType, std::allocator<mxnet::OpReqType>> &, const std::vector<mxnet::TBlob, std::allocator<mxnet::TBlob>> &) [with xpu=mxnet::gpu, OP=mxnet::op::mshadow_op::erfinv]"
   src/operator/tensor/elemwise_unary_op_basic.cu(67): here
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services