You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/03/27 17:54:02 UTC

Review Request 32579: Fix Attributes and Resources documentation.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32579/
-----------------------------------------------------------

Review request for mesos.


Bugs: MESOS-2566
    https://issues.apache.org/jira/browse/MESOS-2566


Repository: mesos


Description
-------

See summary.


Diffs
-----

  docs/attributes-resources.md a65aee3d0792abd7168642c119a041c3b7b97dfc 

Diff: https://reviews.apache.org/r/32579/diff/


Testing
-------


Thanks,

Michael Park

Re: Review Request 32579: Fix Attributes and Resources documentation.

Posted by Joerg Schad <jo...@mesosphere.io>.


> On March 27, 2015, 5:20 p.m., Joerg Schad wrote:
> > lgtm

P.S. checked with Markdown Preview


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32579/#review78076
-----------------------------------------------------------


On March 27, 2015, 4:54 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32579/
> -----------------------------------------------------------
> 
> (Updated March 27, 2015, 4:54 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2566
>     https://issues.apache.org/jira/browse/MESOS-2566
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/attributes-resources.md a65aee3d0792abd7168642c119a041c3b7b97dfc 
> 
> Diff: https://reviews.apache.org/r/32579/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 32579: Fix Attributes and Resources documentation.

Posted by Joerg Schad <jo...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32579/#review78076
-----------------------------------------------------------


lgtm

- Joerg Schad


On March 27, 2015, 4:54 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32579/
> -----------------------------------------------------------
> 
> (Updated March 27, 2015, 4:54 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2566
>     https://issues.apache.org/jira/browse/MESOS-2566
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/attributes-resources.md a65aee3d0792abd7168642c119a041c3b7b97dfc 
> 
> Diff: https://reviews.apache.org/r/32579/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 32579: Fix Attributes and Resources documentation.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32579/#review78087
-----------------------------------------------------------


Patch looks great!

Reviews applied: [32579]

All tests passed.

- Mesos ReviewBot


On March 27, 2015, 4:54 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32579/
> -----------------------------------------------------------
> 
> (Updated March 27, 2015, 4:54 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2566
>     https://issues.apache.org/jira/browse/MESOS-2566
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/attributes-resources.md a65aee3d0792abd7168642c119a041c3b7b97dfc 
> 
> Diff: https://reviews.apache.org/r/32579/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 32579: Fix Attributes and Resources documentation.

Posted by Niklas Nielsen <ni...@qni.dk>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32579/#review78083
-----------------------------------------------------------

Ship it!


Ship It!

- Niklas Nielsen


On March 27, 2015, 9:54 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32579/
> -----------------------------------------------------------
> 
> (Updated March 27, 2015, 9:54 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2566
>     https://issues.apache.org/jira/browse/MESOS-2566
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/attributes-resources.md a65aee3d0792abd7168642c119a041c3b7b97dfc 
> 
> Diff: https://reviews.apache.org/r/32579/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>