You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "Superskyyy (via GitHub)" <gi...@apache.org> on 2023/02/23 02:35:04 UTC
[GitHub] [skywalking-website] Superskyyy opened a new pull request, #571: Release Python agent 1.0.0
Superskyyy opened a new pull request, #571:
URL: https://github.com/apache/skywalking-website/pull/571
Release notes added, version bumped.
Also fixed few nits in other places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] netlify[bot] commented on pull request #571: Release Python agent 1.0.0
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #571:
URL: https://github.com/apache/skywalking-website/pull/571#issuecomment-1441145305
### <span aria-hidden="true">👷</span> Deploy Preview for *skywalking-website-preview* processing.
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 4a1eb806ee720eb19f4a77c2abf03c820a5f5250 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/sites/skywalking-website-preview/deploys/63f6d0d86337c10008a71990 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Superskyyy commented on a diff in pull request #571: Release Python agent 1.0.0
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on code in PR #571:
URL: https://github.com/apache/skywalking-website/pull/571#discussion_r1115197214
##########
data/docs.yml:
##########
@@ -90,20 +90,23 @@
- name: Python Agent
icon: python-agent
- description: The Python Agent for Apache SkyWalking, which provides the native tracing/logging abilities for Python projects.
+ description: The Python Agent for Apache SkyWalking, which provides the native tracing/metrics/logging/profiling abilities for Python projects.
user: apache
repo: skywalking-python
repoUrl: https://github.com/apache/skywalking-python.git
docs:
- version: Next
link: /docs/skywalking-python/next/readme/
+ - version: v1.0.0
+ link: /docs/skywalking-python/next/readme/
+ commitId: 6f745cdbec7cf003c60d71857bf987a280e88430
- version: v0.8.0
Review Comment:
Oh I was confused why Java agent has previous versions while others don't. So I will remove 0.8.0, and keep anything after 1.0.0 in the future right?
##########
data/docs.yml:
##########
@@ -90,20 +90,23 @@
- name: Python Agent
icon: python-agent
- description: The Python Agent for Apache SkyWalking, which provides the native tracing/logging abilities for Python projects.
+ description: The Python Agent for Apache SkyWalking, which provides the native tracing/metrics/logging/profiling abilities for Python projects.
user: apache
repo: skywalking-python
repoUrl: https://github.com/apache/skywalking-python.git
docs:
- version: Next
link: /docs/skywalking-python/next/readme/
+ - version: v1.0.0
+ link: /docs/skywalking-python/next/readme/
+ commitId: 6f745cdbec7cf003c60d71857bf987a280e88430
- version: v0.8.0
Review Comment:
Oh I was confused why Java agent has previous versions while others don't. So I should remove 0.8.0, and keep anything after 1.0.0 in the future right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on a diff in pull request #571: Release Python agent 1.0.0
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #571:
URL: https://github.com/apache/skywalking-website/pull/571#discussion_r1115192824
##########
data/docs.yml:
##########
@@ -90,20 +90,23 @@
- name: Python Agent
icon: python-agent
- description: The Python Agent for Apache SkyWalking, which provides the native tracing/logging abilities for Python projects.
+ description: The Python Agent for Apache SkyWalking, which provides the native tracing/metrics/logging/profiling abilities for Python projects.
user: apache
repo: skywalking-python
repoUrl: https://github.com/apache/skywalking-python.git
docs:
- version: Next
link: /docs/skywalking-python/next/readme/
+ - version: v1.0.0
+ link: /docs/skywalking-python/next/readme/
+ commitId: 6f745cdbec7cf003c60d71857bf987a280e88430
- version: v0.8.0
Review Comment:
As 1.0 is a GA, do we still plan to keep 0.8? Usually previous versions are kept aftrr GA.
##########
data/docs.yml:
##########
@@ -90,20 +90,23 @@
- name: Python Agent
icon: python-agent
- description: The Python Agent for Apache SkyWalking, which provides the native tracing/logging abilities for Python projects.
+ description: The Python Agent for Apache SkyWalking, which provides the native tracing/metrics/logging/profiling abilities for Python projects.
user: apache
repo: skywalking-python
repoUrl: https://github.com/apache/skywalking-python.git
docs:
- version: Next
link: /docs/skywalking-python/next/readme/
+ - version: v1.0.0
+ link: /docs/skywalking-python/next/readme/
+ commitId: 6f745cdbec7cf003c60d71857bf987a280e88430
- version: v0.8.0
Review Comment:
You replaced download page, but keep docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Superskyyy commented on pull request #571: Release Python agent 1.0.0
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on PR #571:
URL: https://github.com/apache/skywalking-website/pull/571#issuecomment-1441166417
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Superskyyy commented on a diff in pull request #571: Release Python agent 1.0.0
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on code in PR #571:
URL: https://github.com/apache/skywalking-website/pull/571#discussion_r1115214252
##########
content/events/release-apache-skywalking-python-1-0-0/index.md:
##########
@@ -12,6 +12,7 @@ SkyWalking Python 1.0.0 is released! Go to [downloads](/downloads) page to find
**DockerHub Image**: https://hub.docker.com/r/apache/skywalking-python
- **Important Notes and Breaking Changes:**
+ - The new PVM metrics reported from Python agent requires SkyWalking OAP v9.3.0 to show out-of-the-box.
Review Comment:
Sure, I will add it later!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on a diff in pull request #571: Release Python agent 1.0.0
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #571:
URL: https://github.com/apache/skywalking-website/pull/571#discussion_r1115217416
##########
content/events/release-apache-skywalking-python-1-0-0/index.md:
##########
@@ -12,6 +12,7 @@ SkyWalking Python 1.0.0 is released! Go to [downloads](/downloads) page to find
**DockerHub Image**: https://hub.docker.com/r/apache/skywalking-python
- **Important Notes and Breaking Changes:**
+ - The new PVM metrics reported from Python agent requires SkyWalking OAP v9.3.0 to show out-of-the-box.
Review Comment:
So, if you want to highlight this, try to write how to activate PVM in older OAP version, or just don't say anything until there is anyone asked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on a diff in pull request #571: Release Python agent 1.0.0
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #571:
URL: https://github.com/apache/skywalking-website/pull/571#discussion_r1115217175
##########
content/events/release-apache-skywalking-python-1-0-0/index.md:
##########
@@ -12,6 +12,7 @@ SkyWalking Python 1.0.0 is released! Go to [downloads](/downloads) page to find
**DockerHub Image**: https://hub.docker.com/r/apache/skywalking-python
- **Important Notes and Breaking Changes:**
+ - The new PVM metrics reported from Python agent requires SkyWalking OAP v9.3.0 to show out-of-the-box.
Review Comment:
PVM is fine. Meter system is there for a long time. The only thing is, user may need MAL script of PVM from a newer version of OAP. But generally, compatibility is still there, nothing wrong would happen w/o that script file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on a diff in pull request #571: Release Python agent 1.0.0
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #571:
URL: https://github.com/apache/skywalking-website/pull/571#discussion_r1115215172
##########
content/events/release-apache-skywalking-python-1-0-0/index.md:
##########
@@ -12,6 +12,7 @@ SkyWalking Python 1.0.0 is released! Go to [downloads](/downloads) page to find
**DockerHub Image**: https://hub.docker.com/r/apache/skywalking-python
- **Important Notes and Breaking Changes:**
+ - The new PVM metrics reported from Python agent requires SkyWalking OAP v9.3.0 to show out-of-the-box.
Review Comment:
Could you be clear, about why does python need 9.3.0? Which protocol is new in 9.3.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Superskyyy commented on a diff in pull request #571: Release Python agent 1.0.0
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on code in PR #571:
URL: https://github.com/apache/skywalking-website/pull/571#discussion_r1115225517
##########
content/events/release-apache-skywalking-python-1-0-0/index.md:
##########
@@ -12,6 +12,7 @@ SkyWalking Python 1.0.0 is released! Go to [downloads](/downloads) page to find
**DockerHub Image**: https://hub.docker.com/r/apache/skywalking-python
- **Important Notes and Breaking Changes:**
+ - The new PVM metrics reported from Python agent requires SkyWalking OAP v9.3.0 to show out-of-the-box.
Review Comment:
I don't think there's other compatibility issues, it's just the PVM tab wouldn't be there out-of-the-box, and no real broken things would happen as said - just need a mal script.
> So, if you want to highlight this, try to write how to activate PVM in older OAP version, or just don't say anything until there is anyone asked.
Got it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Superskyyy commented on a diff in pull request #571: Release Python agent 1.0.0
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on code in PR #571:
URL: https://github.com/apache/skywalking-website/pull/571#discussion_r1115253012
##########
content/events/release-apache-skywalking-python-1-0-0/index.md:
##########
@@ -12,6 +12,7 @@ SkyWalking Python 1.0.0 is released! Go to [downloads](/downloads) page to find
**DockerHub Image**: https://hub.docker.com/r/apache/skywalking-python
- **Important Notes and Breaking Changes:**
+ - The new PVM metrics reported from Python agent requires SkyWalking OAP v9.3.0 to show out-of-the-box.
Review Comment:
I think I won't add it right now, let's wait and see if anyone asks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng merged pull request #571: Release Python agent 1.0.0
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #571:
URL: https://github.com/apache/skywalking-website/pull/571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Superskyyy commented on a diff in pull request #571: Release Python agent 1.0.0
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on code in PR #571:
URL: https://github.com/apache/skywalking-website/pull/571#discussion_r1115197214
##########
data/docs.yml:
##########
@@ -90,20 +90,23 @@
- name: Python Agent
icon: python-agent
- description: The Python Agent for Apache SkyWalking, which provides the native tracing/logging abilities for Python projects.
+ description: The Python Agent for Apache SkyWalking, which provides the native tracing/metrics/logging/profiling abilities for Python projects.
user: apache
repo: skywalking-python
repoUrl: https://github.com/apache/skywalking-python.git
docs:
- version: Next
link: /docs/skywalking-python/next/readme/
+ - version: v1.0.0
+ link: /docs/skywalking-python/next/readme/
+ commitId: 6f745cdbec7cf003c60d71857bf987a280e88430
- version: v0.8.0
Review Comment:
Oh I was confused why Java agent has previous versions while others don't. I will add it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] kezhenxu94 commented on a diff in pull request #571: Release Python agent 1.0.0
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #571:
URL: https://github.com/apache/skywalking-website/pull/571#discussion_r1115216234
##########
content/events/release-apache-skywalking-python-1-0-0/index.md:
##########
@@ -12,6 +12,7 @@ SkyWalking Python 1.0.0 is released! Go to [downloads](/downloads) page to find
**DockerHub Image**: https://hub.docker.com/r/apache/skywalking-python
- **Important Notes and Breaking Changes:**
+ - The new PVM metrics reported from Python agent requires SkyWalking OAP v9.3.0 to show out-of-the-box.
Review Comment:
If it's only the PVM metrics visualization, then I'd consider it "compatible" because it just works, it doesn't required users to update OAP just in order to upgrade to 1.0.0. @Superskyyy please confirm whether there is anything else that breaks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on a diff in pull request #571: Release Python agent 1.0.0
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #571:
URL: https://github.com/apache/skywalking-website/pull/571#discussion_r1115197556
##########
data/docs.yml:
##########
@@ -90,20 +90,23 @@
- name: Python Agent
icon: python-agent
- description: The Python Agent for Apache SkyWalking, which provides the native tracing/logging abilities for Python projects.
+ description: The Python Agent for Apache SkyWalking, which provides the native tracing/metrics/logging/profiling abilities for Python projects.
user: apache
repo: skywalking-python
repoUrl: https://github.com/apache/skywalking-python.git
docs:
- version: Next
link: /docs/skywalking-python/next/readme/
+ - version: v1.0.0
+ link: /docs/skywalking-python/next/readme/
+ commitId: 6f745cdbec7cf003c60d71857bf987a280e88430
- version: v0.8.0
Review Comment:
It is stable, and many ppl are keeping in some old releases. I think Python would face that day as you have tagged GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on a diff in pull request #571: Release Python agent 1.0.0
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #571:
URL: https://github.com/apache/skywalking-website/pull/571#discussion_r1115213804
##########
content/events/release-apache-skywalking-python-1-0-0/index.md:
##########
@@ -12,6 +12,7 @@ SkyWalking Python 1.0.0 is released! Go to [downloads](/downloads) page to find
**DockerHub Image**: https://hub.docker.com/r/apache/skywalking-python
- **Important Notes and Breaking Changes:**
+ - The new PVM metrics reported from Python agent requires SkyWalking OAP v9.3.0 to show out-of-the-box.
Review Comment:
If python agent is somehow version sensitive for v9, please document here.
https://github.com/apache/skywalking/blob/master/docs/en/setup/service-agent/agent-compatibility.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org