You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lquerel (via GitHub)" <gi...@apache.org> on 2023/02/15 17:48:39 UTC
[GitHub] [arrow] lquerel opened a new pull request, #34207: Add arrow.MapOfWithMetadata to support #34186
lquerel opened a new pull request, #34207:
URL: https://github.com/apache/arrow/pull/34207
@zeroshade - issue #34186
The signature of MapType constructor is func MapOf(key, item DataType) *MapType. The field MapType.value is private and the pointer returned by MapType.ValueType doesn't give access to the fields of the underlying StructType.
I propose to add an additional constructor to specificy these metadata with the following signature:
```go
func MapOfWithMetadata(
keyDT DataType,
keyMetadata Metadata,
valueDT DataType,
valueMetadata Metadata,
) *MapType
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #34207: GH-34186: [Go] Add arrow.MapOfWithMetadata to support
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #34207:
URL: https://github.com/apache/arrow/pull/34207#issuecomment-1431782419
@lquerel Please undo the changes you made to the go.mod / go.sum file, that's the cause of all the CI failures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34207: GH-34186: [Go] Add arrow.MapOfWithMetadata to support
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34207:
URL: https://github.com/apache/arrow/pull/34207#issuecomment-1432323624
['Python', 'R'] benchmarks have high level of regressions.
[test-mac-arm](https://conbench.ursa.dev/compare/runs/9f1f1b50e8b44fde8fc8893bfb295101...88ecad3e0a294de0a0785e6c4131364d/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade merged pull request #34207: GH-34186: [Go] Add arrow.MapOfWithMetadata to support
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #34207:
URL: https://github.com/apache/arrow/pull/34207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34207: GH-34186: [Go] Add arrow.MapOfWithMetadata to support
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34207:
URL: https://github.com/apache/arrow/pull/34207#issuecomment-1431780151
* Closes: #34186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34207: Add arrow.MapOfWithMetadata to support #34186
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34207:
URL: https://github.com/apache/arrow/pull/34207#issuecomment-1431768786
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34207: GH-34186: [Go] Add arrow.MapOfWithMetadata to support
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34207:
URL: https://github.com/apache/arrow/pull/34207#issuecomment-1431780226
:warning: GitHub issue #34186 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34207: GH-34186: [Go] Add arrow.MapOfWithMetadata to support
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34207:
URL: https://github.com/apache/arrow/pull/34207#issuecomment-1432320681
Benchmark runs are scheduled for baseline = 798b417ec342051f3ff30b9953dcb1f1b71dc9e8 and contender = c857d87f33fa9d26909250fb6f7e1dcc8b590af6. c857d87f33fa9d26909250fb6f7e1dcc8b590af6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7627303b2c8a482c836491a4b27a861c...5eaa96c10be74f1ca517f7a428ed2ae1/)
[Failed :arrow_down:0.18% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/9f1f1b50e8b44fde8fc8893bfb295101...88ecad3e0a294de0a0785e6c4131364d/)
[Finished :arrow_down:0.26% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f8543db9d7d1402a90f8b65ceda6c948...8955f39f4c9c4ba0b02a66eb6a964443/)
[Finished :arrow_down:0.22% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/1a155dd4c59949889aa2b1854ef28a13...e14b91de6a1b465a840d0f142c76cfa3/)
Buildkite builds:
[Finished] [`c857d87f` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2379)
[Failed] [`c857d87f` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2409)
[Finished] [`c857d87f` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2377)
[Finished] [`c857d87f` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2401)
[Finished] [`798b417e` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2378)
[Finished] [`798b417e` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2408)
[Finished] [`798b417e` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2376)
[Finished] [`798b417e` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2400)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lquerel commented on pull request #34207: GH-34186: [Go] Add arrow.MapOfWithMetadata to support
Posted by "lquerel (via GitHub)" <gi...@apache.org>.
lquerel commented on PR #34207:
URL: https://github.com/apache/arrow/pull/34207#issuecomment-1431811639
@zeroshade I undo the changes I made with `go mod tidy`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org