You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "liujiayi771 (via GitHub)" <gi...@apache.org> on 2024/03/14 14:51:57 UTC
[PR] [VL] Add velox decimal avg sum large precision test case [incubator-gluten]
liujiayi771 opened a new pull request, #4961:
URL: https://github.com/apache/incubator-gluten/pull/4961
## What changes were proposed in this pull request?
When the input decimal precision is very large, the precision of sum and avg may exceed 38, and we should not infer the intermediate type based on the result type in decimal sum/avg functions, we should always infer the intermediate type and result type based on the raw input type.
For example, in average aggregate function:
input = decimal(p, s)
intermediate = row(decimal(min(38, p + 10), s), bigint)
result = decimal(min(38, p + 4), min(38, s + 4))
We should not infer intermediate type by using result precision + 6, it is not correct when p > 34.
Add some test cases with large precision to prevent future modifications to decimal avg sum from introducing errors.
## How was this patch tested?
Add large precision test cases in avg and sum `VeloxAggregateFunctionsSuite`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Add velox decimal avg sum large precision test case [incubator-gluten]
Posted by "liujiayi771 (via GitHub)" <gi...@apache.org>.
liujiayi771 commented on PR #4961:
URL: https://github.com/apache/incubator-gluten/pull/4961#issuecomment-1997643266
cc @rui-mo, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Add velox decimal avg sum large precision test case [incubator-gluten]
Posted by "GlutenPerfBot (via GitHub)" <gi...@apache.org>.
GlutenPerfBot commented on PR #4961:
URL: https://github.com/apache/incubator-gluten/pull/4961#issuecomment-2005992499
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
<table border="1" cellpadding="0" cellspacing="0">
<tbody>
<tr>
<td><font color=#000000>query</font></td>
<td><font color=#000000>log/native_4961_time.csv</font></td>
<td><font color=#000000>log/native_master_03_18_2024_81b023eda_time.csv</font></td>
<td><font color=#000000>difference</font></td>
<td><font color=#000000>percentage</font></td>
</tr>
<tr>
<td><font color=#6F9915>q1</font></td>
<td><font color=#6F9915>35.41</font></td>
<td><font color=#6F9915>34.55</font></td>
<td><font color=#6F9915>-0.857</font></td>
<td><font color=#6F9915>97.58%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q2</font></td>
<td><font color=#6F9915>25.96</font></td>
<td><font color=#6F9915>23.93</font></td>
<td><font color=#6F9915>-2.026</font></td>
<td><font color=#6F9915>92.19%</font></td>
</tr>
<tr>
<td><font color=#F92663>q3</font></td>
<td><font color=#F92663>36.41</font></td>
<td><font color=#F92663>37.82</font></td>
<td><font color=#F92663>1.405</font></td>
<td><font color=#F92663>103.86%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q4</font></td>
<td><font color=#6F9915>38.82</font></td>
<td><font color=#6F9915>38.56</font></td>
<td><font color=#6F9915>-0.257</font></td>
<td><font color=#6F9915>99.34%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q5</font></td>
<td><font color=#6F9915>71.38</font></td>
<td><font color=#6F9915>70.54</font></td>
<td><font color=#6F9915>-0.840</font></td>
<td><font color=#6F9915>98.82%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q6</font></td>
<td><font color=#6F9915>7.63</font></td>
<td><font color=#6F9915>7.37</font></td>
<td><font color=#6F9915>-0.263</font></td>
<td><font color=#6F9915>96.56%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q7</font></td>
<td><font color=#6F9915>85.75</font></td>
<td><font color=#6F9915>82.54</font></td>
<td><font color=#6F9915>-3.214</font></td>
<td><font color=#6F9915>96.25%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q8</font></td>
<td><font color=#6F9915>84.24</font></td>
<td><font color=#6F9915>83.80</font></td>
<td><font color=#6F9915>-0.444</font></td>
<td><font color=#6F9915>99.47%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q9</font></td>
<td><font color=#6F9915>125.69</font></td>
<td><font color=#6F9915>122.07</font></td>
<td><font color=#6F9915>-3.619</font></td>
<td><font color=#6F9915>97.12%</font></td>
</tr>
<tr>
<td><font color=#F92663>q10</font></td>
<td><font color=#F92663>43.47</font></td>
<td><font color=#F92663>47.80</font></td>
<td><font color=#F92663>4.329</font></td>
<td><font color=#F92663>109.96%</font></td>
</tr>
<tr>
<td><font color=#F92663>q11</font></td>
<td><font color=#F92663>19.74</font></td>
<td><font color=#F92663>20.52</font></td>
<td><font color=#F92663>0.780</font></td>
<td><font color=#F92663>103.95%</font></td>
</tr>
<tr>
<td><font color=#F92663>q12</font></td>
<td><font color=#F92663>27.50</font></td>
<td><font color=#F92663>29.90</font></td>
<td><font color=#F92663>2.406</font></td>
<td><font color=#F92663>108.75%</font></td>
</tr>
<tr>
<td><font color=#F92663>q13</font></td>
<td><font color=#F92663>48.11</font></td>
<td><font color=#F92663>48.72</font></td>
<td><font color=#F92663>0.614</font></td>
<td><font color=#F92663>101.28%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q14</font></td>
<td><font color=#6F9915>23.49</font></td>
<td><font color=#6F9915>16.49</font></td>
<td><font color=#6F9915>-7.004</font></td>
<td><font color=#6F9915>70.19%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q15</font></td>
<td><font color=#6F9915>31.03</font></td>
<td><font color=#6F9915>29.10</font></td>
<td><font color=#6F9915>-1.932</font></td>
<td><font color=#6F9915>93.77%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q16</font></td>
<td><font color=#6F9915>14.35</font></td>
<td><font color=#6F9915>13.70</font></td>
<td><font color=#6F9915>-0.645</font></td>
<td><font color=#6F9915>95.50%</font></td>
</tr>
<tr>
<td><font color=#F92663>q17</font></td>
<td><font color=#F92663>100.35</font></td>
<td><font color=#F92663>100.81</font></td>
<td><font color=#F92663>0.464</font></td>
<td><font color=#F92663>100.46%</font></td>
</tr>
<tr>
<td><font color=#F92663>q18</font></td>
<td><font color=#F92663>142.43</font></td>
<td><font color=#F92663>143.37</font></td>
<td><font color=#F92663>0.942</font></td>
<td><font color=#F92663>100.66%</font></td>
</tr>
<tr>
<td><font color=#F92663>q19</font></td>
<td><font color=#F92663>14.60</font></td>
<td><font color=#F92663>15.76</font></td>
<td><font color=#F92663>1.168</font></td>
<td><font color=#F92663>108.00%</font></td>
</tr>
<tr>
<td><font color=#F92663>q20</font></td>
<td><font color=#F92663>28.42</font></td>
<td><font color=#F92663>28.60</font></td>
<td><font color=#F92663>0.185</font></td>
<td><font color=#F92663>100.65%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q21</font></td>
<td><font color=#6F9915>227.35</font></td>
<td><font color=#6F9915>225.81</font></td>
<td><font color=#6F9915>-1.542</font></td>
<td><font color=#6F9915>99.32%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q22</font></td>
<td><font color=#6F9915>14.07</font></td>
<td><font color=#6F9915>14.02</font></td>
<td><font color=#6F9915>-0.048</font></td>
<td><font color=#6F9915>99.66%</font></td>
</tr>
<tr>
<td><font color=#6F9915>total</font></td>
<td><font color=#6F9915>1246.20</font></td>
<td><font color=#6F9915>1235.80</font></td>
<td><font color=#6F9915>-10.398</font></td>
<td><font color=#6F9915>99.17%</font></td>
</tr>
</tbody>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Add velox decimal avg sum large precision test case [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4961:
URL: https://github.com/apache/incubator-gluten/pull/4961#issuecomment-1997642408
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICEGJ-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
https://github.com/apache/incubator-gluten/issues
Then could you also rename ***commit message*** and ***pull request title*** in the following format?
[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
See also:
* [Other pull requests](https://github.com/apache/incubator-gluten/pulls/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Add velox decimal avg sum large precision test case [incubator-gluten]
Posted by "rui-mo (via GitHub)" <gi...@apache.org>.
rui-mo merged PR #4961:
URL: https://github.com/apache/incubator-gluten/pull/4961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org