You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Hzfengsy (via GitHub)" <gi...@apache.org> on 2025/09/24 11:05:25 UTC

[PR] [TIR] Support sequence comparisons in TVMScript [tvm]

Hzfengsy opened a new pull request, #18341:
URL: https://github.com/apache/tvm/pull/18341

   Implement proper parsing and evaluation of chained comparison operators (e.g., `0 < i < 128`) in TVMScript. The sequence comparisons are now correctly expanded to their logical equivalents (e.g., `(0 < i and i < 128)`).
   
   cc @LeiWang1999 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [TIR] Support sequence comparisons in TVMScript [tvm]

Posted by "MasterJH5574 (via GitHub)" <gi...@apache.org>.
MasterJH5574 merged PR #18341:
URL: https://github.com/apache/tvm/pull/18341


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [TIR] Support sequence comparisons in TVMScript [tvm]

Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #18341:
URL: https://github.com/apache/tvm/pull/18341#discussion_r2375404488


##########
python/tvm/script/parser/core/evaluator.py:
##########
@@ -324,10 +324,18 @@ def _eval_compare(self, fields: Dict[str, Any]) -> Any:
         res : Any
             The evaluation result.
         """
-        value = self._eval_expr(fields["left"])
-        for op, rhs in zip(fields["ops"], fields["comparators"]):
-            value = _eval_op(op, values=[value, self._eval_expr(rhs)])
-        return value
+        values = [self._eval_expr(fields["left"])]
+        values.extend([self._eval_expr(rhs) for rhs in fields["comparators"]])
+        result = None
+        assert len(fields["ops"]) == len(values) - 1
+
+        for index, op in enumerate(fields["ops"]):
+            sub_result = _eval_op(op, values=[values[index], values[index + 1]])
+            if result is None:
+                result = sub_result
+            else:
+                result = _eval_op(doc.And(), values=[result, sub_result])
+        return result

Review Comment:
   ![high](https://www.gstatic.com/codereviewagent/high-priority.svg)
   
   The current implementation evaluates all comparator expressions upfront. This deviates from Python's chained comparison semantics, which use short-circuiting and evaluate expressions sequentially. For an expression like `a < b < f()` where `f()` has side effects, `f()` should not be called if `a < b` is false. Eagerly evaluating all expressions can lead to incorrect behavior in such cases.
   
   The implementation should be updated to evaluate expressions one by one within a loop, carrying over the value of the previous right-hand side for the next comparison. This ensures that each intermediate expression is evaluated only once and in the correct order, matching Python's behavior.
   
   ```python
           left_val = self._eval_expr(fields["left"])
           result = None
   
           # Per Python's chained comparison semantics, intermediate expressions
           # are evaluated only once and in order. This loop structure ensures that.
           # For example, `a < b < c` is equivalent to `a < b and b < c`.
           for op, comparator_expr in zip(fields["ops"], fields["comparators"]):
               right_val = self._eval_expr(comparator_expr)
               sub_result = _eval_op(op, values=[left_val, right_val])
               if result is None:
                   result = sub_result
               else:
                   result = _eval_op(doc.And(), values=[result, sub_result])
               left_val = right_val
           return result
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [TIR] Support sequence comparisons in TVMScript [tvm]

Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #18341:
URL: https://github.com/apache/tvm/pull/18341#issuecomment-3327799423

   ## Summary of Changes
   
   Hello @Hzfengsy, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
   
   This pull request enhances TVMScript's expressiveness by introducing support for Python-style chained comparison operators. This change ensures that complex conditional statements involving multiple comparisons are correctly parsed and evaluated, translating them into their equivalent logical AND expressions. The update improves the fidelity of TVMScript to Python's syntax and semantics for comparison operations.
   
   ### Highlights
   
   * **Chained Comparison Support**: Implemented proper parsing and evaluation of chained comparison operators (e.g., "0 < i < 128") in TVMScript.
   * **Logical Expansion**: Sequence comparisons are now correctly expanded to their logical equivalents, such as "(0 < i and i < 128)".
   * **Core Evaluator Update**: The `_eval_compare` method in `python/tvm/script/parser/core/evaluator.py` was refactored to handle multiple comparisons by evaluating each segment and combining the results with logical AND operations.
   * **New Test Case**: A new test `test_sequence_compare` was added to `tests/python/tvmscript/test_tvmscript_parser_tir.py` to validate the correct behavior of sequence comparisons.
   
   
   
   
   
   
   
   <details>
   <summary><b>Using Gemini Code Assist</b></summary>
   <br>
   
   The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
   
   <b>Invoking Gemini</b>
   
   You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
   
   Feature | Command | Description
   --- | --- | ---
   Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
   Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
   Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
   Help | `/gemini help` | Displays a list of available commands.
   
   <b>Customization</b>
   
   To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
   
   <b>Limitations & Feedback</b>
   
   Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
   
   <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b>
   </details>
   
   
   
   
   [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org