You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cxf.apache.org by ay...@apache.org on 2012/10/17 18:54:29 UTC

svn commit: r1399340 - in /cxf/branches/2.6.x-fixes: ./ api/src/main/java/org/apache/cxf/staxutils/transform/ api/src/test/java/org/apache/cxf/staxutils/transform/

Author: ay
Date: Wed Oct 17 16:54:28 2012
New Revision: 1399340

URL: http://svn.apache.org/viewvc?rev=1399340&view=rev
Log:
Merged revisions 1398490 via  svn merge from
https://svn.apache.org/repos/asf/cxf/trunk

........
  r1398490 | ay | 2012-10-15 22:16:14 +0200 (Mon, 15 Oct 2012) | 1 line
  
  reverting the fix for CXF-4566
........

Modified:
    cxf/branches/2.6.x-fixes/   (props changed)
    cxf/branches/2.6.x-fixes/api/src/main/java/org/apache/cxf/staxutils/transform/InTransformReader.java
    cxf/branches/2.6.x-fixes/api/src/main/java/org/apache/cxf/staxutils/transform/OutTransformWriter.java
    cxf/branches/2.6.x-fixes/api/src/main/java/org/apache/cxf/staxutils/transform/TransformUtils.java
    cxf/branches/2.6.x-fixes/api/src/test/java/org/apache/cxf/staxutils/transform/OutTransformWriterTest.java

Propchange: cxf/branches/2.6.x-fixes/
------------------------------------------------------------------------------
Binary property 'svnmerge-integrated' - no diff available.

Modified: cxf/branches/2.6.x-fixes/api/src/main/java/org/apache/cxf/staxutils/transform/InTransformReader.java
URL: http://svn.apache.org/viewvc/cxf/branches/2.6.x-fixes/api/src/main/java/org/apache/cxf/staxutils/transform/InTransformReader.java?rev=1399340&r1=1399339&r2=1399340&view=diff
==============================================================================
--- cxf/branches/2.6.x-fixes/api/src/main/java/org/apache/cxf/staxutils/transform/InTransformReader.java (original)
+++ cxf/branches/2.6.x-fixes/api/src/main/java/org/apache/cxf/staxutils/transform/InTransformReader.java Wed Oct 17 16:54:28 2012
@@ -306,8 +306,6 @@ public class InTransformReader extends D
         String actualNs = nsMap.get(ns);
         if (actualNs != null) {
             return actualNs;
-        } else if (ns.equals(reader.getNamespaceURI())) {
-            return getNamespaceURI();
         } else {
             return ns;
         }
@@ -322,8 +320,6 @@ public class InTransformReader extends D
             } else {
                 return "";
             }
-        } else if (ns.equals(reader.getNamespaceURI())) {
-            return getPrefix();
         } else {
             return namespaceContext.getPrefix(ns);
         }

Modified: cxf/branches/2.6.x-fixes/api/src/main/java/org/apache/cxf/staxutils/transform/OutTransformWriter.java
URL: http://svn.apache.org/viewvc/cxf/branches/2.6.x-fixes/api/src/main/java/org/apache/cxf/staxutils/transform/OutTransformWriter.java?rev=1399340&r1=1399339&r2=1399340&view=diff
==============================================================================
--- cxf/branches/2.6.x-fixes/api/src/main/java/org/apache/cxf/staxutils/transform/OutTransformWriter.java (original)
+++ cxf/branches/2.6.x-fixes/api/src/main/java/org/apache/cxf/staxutils/transform/OutTransformWriter.java Wed Oct 17 16:54:28 2012
@@ -108,13 +108,11 @@ public class OutTransformWriter extends 
         
         if (defaultNamespace != null && defaultNamespace.equals(uri)) {
             super.writeDefaultNamespace(uri);
-            namespaceContext.addPrefix("", uri);
         } else {
             if (prefix.length() == 0) {
                 prefix = namespaceContext.findUniquePrefix(uri);
             }
             super.writeNamespace(prefix, uri);
-            namespaceContext.addPrefix(prefix, uri);
         }
         writtenUris.get(0).add(uri);
     }
@@ -137,7 +135,7 @@ public class OutTransformWriter extends 
             return;
         }
         super.writeDefaultNamespace(uri);
-        namespaceContext.addPrefix("", uri);
+
         writtenUris.get(0).add(uri);
     }
 
@@ -365,13 +363,13 @@ public class OutTransformWriter extends 
                 namespaceContext.addPrefix(prefix, qname.getNamespaceURI());    
             }
             
-        } 
+        }
         if (isDefaultNamespaceRedefined(qname.getNamespaceURI())) {
             prefix = "";
         }
+        
         super.writeStartElement(prefix, qname.getLocalPart(), qname.getNamespaceURI());
-        if (writeNs 
-            || !qname.getNamespaceURI().equals(namespaceContext.getNamespaceURI(prefix))) {
+        if (writeNs) {
             this.writeNamespace(prefix, qname.getNamespaceURI());
         }
     }

Modified: cxf/branches/2.6.x-fixes/api/src/main/java/org/apache/cxf/staxutils/transform/TransformUtils.java
URL: http://svn.apache.org/viewvc/cxf/branches/2.6.x-fixes/api/src/main/java/org/apache/cxf/staxutils/transform/TransformUtils.java?rev=1399340&r1=1399339&r2=1399340&view=diff
==============================================================================
--- cxf/branches/2.6.x-fixes/api/src/main/java/org/apache/cxf/staxutils/transform/TransformUtils.java (original)
+++ cxf/branches/2.6.x-fixes/api/src/main/java/org/apache/cxf/staxutils/transform/TransformUtils.java Wed Oct 17 16:54:28 2012
@@ -97,8 +97,7 @@ public final class TransformUtils {
                 QName lname = XMLUtils.convertStringToQName(entry.getKey());
                 QName rname = XMLUtils.convertStringToQName(entry.getValue());
                 elementsMap.put(lname, rname);
-                if (nsMap != null && !isEmptyQName(rname)
-                    && ("*".equals(lname.getLocalPart()) && "*".equals(rname.getLocalPart()))) {
+                if (nsMap != null && !isEmptyQName(rname)) {
                     nsMap.put(lname.getNamespaceURI(), rname.getNamespaceURI());
                 }
             }

Modified: cxf/branches/2.6.x-fixes/api/src/test/java/org/apache/cxf/staxutils/transform/OutTransformWriterTest.java
URL: http://svn.apache.org/viewvc/cxf/branches/2.6.x-fixes/api/src/test/java/org/apache/cxf/staxutils/transform/OutTransformWriterTest.java?rev=1399340&r1=1399339&r2=1399340&view=diff
==============================================================================
--- cxf/branches/2.6.x-fixes/api/src/test/java/org/apache/cxf/staxutils/transform/OutTransformWriterTest.java (original)
+++ cxf/branches/2.6.x-fixes/api/src/test/java/org/apache/cxf/staxutils/transform/OutTransformWriterTest.java Wed Oct 17 16:54:28 2012
@@ -115,9 +115,9 @@ public class OutTransformWriterTest exte
         String xmlPI = "<?xml version='1.0' encoding='UTF-8'?>";
         String start = "<testBean xmlns=\"http://testbeans.com/v2\"";
         String expected1 = xmlPI + start
-            + " xmlns:ps1=\"http://testbeans.com/v3\"><ps1:bean/></testBean>";
+            + " xmlns:ps2=\"http://testbeans.com/v3\"><ps2:bean/></testBean>";
         String expected2 = xmlPI + start
-            + "><ps1:bean xmlns:ps1=\"http://testbeans.com/v3\"/></testBean>";
+            + "><ps2:bean xmlns:ps2=\"http://testbeans.com/v3\"/></testBean>";
         String out = os.toString();
         assertTrue("Output \"" + out + "\" does not match expected values",
                 expected1.equals(out) || expected2.equals(out));
@@ -286,9 +286,10 @@ public class OutTransformWriterTest exte
     }
 
     @Test
+    @org.junit.Ignore
     public void testRemoveOneNamespace() throws Exception {
         Map<String, String> inMap = new HashMap<String, String>();
-        inMap.put("{http://www.chinamobile.com/vgop/serviceorder/v1_0}result", "result"); 
+        inMap.put("{http://cxf.apache.org/vgop/serviceorder/v1_0}result", "result"); 
         XMLStreamReader reader = 
             TransformTestUtils.createOutTransformedStreamReader("../resources/complexReqIn5.xml", 
                                                                 inMap, null, null, null, false, null);