[jira] Resolved: (HTTPCLIENT-895) Log creation impairs performance

["Oleg Kalnichevski (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPCLIENT-895.
------------------------------------------

    Resolution: Fixed

Fixed in SVN trunk and 4.0.x branch. Please review / test

Oleg



> Log creation impairs performance
> --------------------------------
>
>                 Key: HTTPCLIENT-895
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-895
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>    Affects Versions: 4.0 Final
>            Reporter: Tony Poppleton
>             Fix For: 4.0.1, 4.1 Alpha1
>
>         Attachments: HTTPCLIENT-895.patch
>
>
> Running JProfiler on a program that uses HttpClient with a ThreadSafeClientConnManager, revealed that 5% of the time was spent constructing Log instances in class ClientParamsStack.
> Oleg did some further investigation and found that DefaultRequestDirector also has the same problem.
> A simple solution would be to make the Log a static member variable, and do this on all classes for consistency.  However this might not be the best solution for interoperating with some frameworks (see http://wiki.apache.org/jakarta-commons/Logging/StaticLog)
> Another solution would be to simply remove the Log from the affected classes, although they are presumably there for a reason...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org