You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "nvollmar (via GitHub)" <gi...@apache.org> on 2023/05/10 05:10:14 UTC
[GitHub] [incubator-pekko-persistence-cassandra] nvollmar opened a new pull request, #46: Apply compat changes from latest Pekko
nvollmar opened a new pull request, #46:
URL: https://github.com/apache/incubator-pekko-persistence-cassandra/pull/46
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-cassandra] mdedetrich commented on pull request #46: Apply compat changes from latest Pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #46:
URL: https://github.com/apache/incubator-pekko-persistence-cassandra/pull/46#issuecomment-1543764990
Publish action has been manually triggered https://github.com/apache/incubator-pekko-persistence-cassandra/actions/runs/4946991536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-cassandra] mdedetrich commented on a diff in pull request #46: Apply compat changes from latest Pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #46:
URL: https://github.com/apache/incubator-pekko-persistence-cassandra/pull/46#discussion_r1190836884
##########
project/Dependencies.scala:
##########
@@ -17,16 +17,16 @@ object Dependencies {
val scala3Version = "3.1.2" // not yet enabled - missing pekko-http/pekko-management Scala 3 artifacts
val scalaVersions = Seq(scala212Version, scala213Version)
- val pekkoVersion = System.getProperty("override.pekko.version", "0.0.0+26630-2c4d0ee0-SNAPSHOT")
+ val pekkoVersion = System.getProperty("override.pekko.version", "0.0.0+26656-898c6970-SNAPSHOT")
val pekkoVersionInDocs = "current"
val cassandraVersionInDocs = "4.0"
// Should be sync with the version of the driver in Pekko Connectors Cassandra
val driverVersionInDocs = "4.6"
- val pekkoConnectorsVersion = "0.0.0+64-20da4165-SNAPSHOT"
+ val pekkoConnectorsVersion = "0.0.0+82-5880466e-SNAPSHOT"
Review Comment:
@nvollmar 0.0.0+85-a82f3c3c-SNAPSHOT was just released
##########
project/Dependencies.scala:
##########
@@ -17,16 +17,16 @@ object Dependencies {
val scala3Version = "3.1.2" // not yet enabled - missing pekko-http/pekko-management Scala 3 artifacts
val scalaVersions = Seq(scala212Version, scala213Version)
- val pekkoVersion = System.getProperty("override.pekko.version", "0.0.0+26630-2c4d0ee0-SNAPSHOT")
+ val pekkoVersion = System.getProperty("override.pekko.version", "0.0.0+26656-898c6970-SNAPSHOT")
val pekkoVersionInDocs = "current"
val cassandraVersionInDocs = "4.0"
// Should be sync with the version of the driver in Pekko Connectors Cassandra
val driverVersionInDocs = "4.6"
- val pekkoConnectorsVersion = "0.0.0+64-20da4165-SNAPSHOT"
+ val pekkoConnectorsVersion = "0.0.0+82-5880466e-SNAPSHOT"
Review Comment:
@nvollmar `0.0.0+85-a82f3c3c-SNAPSHOT` was just released
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-cassandra] mdedetrich commented on a diff in pull request #46: Apply compat changes from latest Pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #46:
URL: https://github.com/apache/incubator-pekko-persistence-cassandra/pull/46#discussion_r1190897558
##########
project/Dependencies.scala:
##########
@@ -49,6 +49,7 @@ object Dependencies {
"org.apache.pekko" %% "pekko-connectors-cassandra" % pekkoConnectorsVersion,
"org.apache.pekko" %% "pekko-persistence" % pekkoVersion,
"org.apache.pekko" %% "pekko-persistence-query" % pekkoVersion,
+ "org.apache.pekko" %% "pekko-stream" % pekkoVersion,
Review Comment:
Fair enough 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-cassandra] mdedetrich commented on a diff in pull request #46: Apply compat changes from latest Pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #46:
URL: https://github.com/apache/incubator-pekko-persistence-cassandra/pull/46#discussion_r1190894767
##########
project/Dependencies.scala:
##########
@@ -49,6 +49,7 @@ object Dependencies {
"org.apache.pekko" %% "pekko-connectors-cassandra" % pekkoConnectorsVersion,
"org.apache.pekko" %% "pekko-persistence" % pekkoVersion,
"org.apache.pekko" %% "pekko-persistence-query" % pekkoVersion,
+ "org.apache.pekko" %% "pekko-stream" % pekkoVersion,
Review Comment:
So I suspect that you originally added this because you had mismatched snapshot versions, if this is the case I suspect that if you remove this dependency it should still work/pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-cassandra] nvollmar commented on a diff in pull request #46: Apply compat changes from latest Pekko
Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar commented on code in PR #46:
URL: https://github.com/apache/incubator-pekko-persistence-cassandra/pull/46#discussion_r1190851059
##########
project/Dependencies.scala:
##########
@@ -17,16 +17,16 @@ object Dependencies {
val scala3Version = "3.1.2" // not yet enabled - missing pekko-http/pekko-management Scala 3 artifacts
val scalaVersions = Seq(scala212Version, scala213Version)
- val pekkoVersion = System.getProperty("override.pekko.version", "0.0.0+26630-2c4d0ee0-SNAPSHOT")
+ val pekkoVersion = System.getProperty("override.pekko.version", "0.0.0+26656-898c6970-SNAPSHOT")
val pekkoVersionInDocs = "current"
val cassandraVersionInDocs = "4.0"
// Should be sync with the version of the driver in Pekko Connectors Cassandra
val driverVersionInDocs = "4.6"
- val pekkoConnectorsVersion = "0.0.0+64-20da4165-SNAPSHOT"
+ val pekkoConnectorsVersion = "0.0.0+82-5880466e-SNAPSHOT"
Review Comment:
thanks, will upgrade and re-test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-cassandra] nvollmar commented on a diff in pull request #46: Apply compat changes from latest Pekko
Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar commented on code in PR #46:
URL: https://github.com/apache/incubator-pekko-persistence-cassandra/pull/46#discussion_r1189863311
##########
project/Dependencies.scala:
##########
@@ -17,16 +17,16 @@ object Dependencies {
val scala3Version = "3.1.2" // not yet enabled - missing pekko-http/pekko-management Scala 3 artifacts
val scalaVersions = Seq(scala212Version, scala213Version)
- val pekkoVersion = System.getProperty("override.pekko.version", "0.0.0+26630-2c4d0ee0-SNAPSHOT")
+ val pekkoVersion = System.getProperty("override.pekko.version", "0.0.0+26656-898c6970-SNAPSHOT")
val pekkoVersionInDocs = "current"
val cassandraVersionInDocs = "4.0"
// Should be sync with the version of the driver in Pekko Connectors Cassandra
val driverVersionInDocs = "4.6"
- val pekkoConnectorsVersion = "0.0.0+64-20da4165-SNAPSHOT"
+ val pekkoConnectorsVersion = "0.0.0+82-5880466e-SNAPSHOT"
Review Comment:
yep, I've to wait for a new pekko build with those changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-cassandra] nvollmar commented on a diff in pull request #46: Apply compat changes from latest Pekko
Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar commented on code in PR #46:
URL: https://github.com/apache/incubator-pekko-persistence-cassandra/pull/46#discussion_r1189863808
##########
core/src/main/scala/org/apache/pekko/persistence/cassandra/query/EventsByPersistenceIdStage.scala:
##########
@@ -16,16 +16,16 @@ package org.apache.pekko.persistence.cassandra.query
import com.datastax.oss.driver.api.core.CqlSession
import com.datastax.oss.driver.api.core.cql._
import org.apache.pekko
-import pekko.Done
-import pekko.annotation.InternalApi
-import pekko.persistence.cassandra.PluginSettings
-import pekko.stream.stage._
-import pekko.stream.{ Attributes, Outlet, SourceShape }
+import org.apache.pekko.Done
Review Comment:
will revert, organize import automatically broke that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-cassandra] mdedetrich commented on pull request #46: Apply compat changes from latest Pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #46:
URL: https://github.com/apache/incubator-pekko-persistence-cassandra/pull/46#issuecomment-1543701320
Tests passed @nvollmar you want to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-cassandra] mdedetrich commented on a diff in pull request #46: Apply compat changes from latest Pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #46:
URL: https://github.com/apache/incubator-pekko-persistence-cassandra/pull/46#discussion_r1189765346
##########
core/src/main/scala/org/apache/pekko/persistence/cassandra/query/EventsByPersistenceIdStage.scala:
##########
@@ -16,16 +16,16 @@ package org.apache.pekko.persistence.cassandra.query
import com.datastax.oss.driver.api.core.CqlSession
import com.datastax.oss.driver.api.core.cql._
import org.apache.pekko
-import pekko.Done
-import pekko.annotation.InternalApi
-import pekko.persistence.cassandra.PluginSettings
-import pekko.stream.stage._
-import pekko.stream.{ Attributes, Outlet, SourceShape }
+import org.apache.pekko.Done
Review Comment:
Can we keep the `pekko` prefix here rather than using `org.apache.pekko`. While there is an argument to use the FQCN the community needs to decide on this and it will likely be done as part of a scalafix integration.
##########
project/Dependencies.scala:
##########
@@ -17,16 +17,16 @@ object Dependencies {
val scala3Version = "3.1.2" // not yet enabled - missing pekko-http/pekko-management Scala 3 artifacts
val scalaVersions = Seq(scala212Version, scala213Version)
- val pekkoVersion = System.getProperty("override.pekko.version", "0.0.0+26630-2c4d0ee0-SNAPSHOT")
+ val pekkoVersion = System.getProperty("override.pekko.version", "0.0.0+26656-898c6970-SNAPSHOT")
val pekkoVersionInDocs = "current"
val cassandraVersionInDocs = "4.0"
// Should be sync with the version of the driver in Pekko Connectors Cassandra
val driverVersionInDocs = "4.6"
- val pekkoConnectorsVersion = "0.0.0+64-20da4165-SNAPSHOT"
+ val pekkoConnectorsVersion = "0.0.0+82-5880466e-SNAPSHOT"
Review Comment:
So I am currently working on pekko-connectors (see https://github.com/apache/incubator-pekko-connectors/pull/101) and there are some blocking upstream changes needed to get it to work.
Due to dependency management hell, it would be ideal to release pekko-connectors once that PR is merged and use that version here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-cassandra] nvollmar commented on a diff in pull request #46: Apply compat changes from latest Pekko
Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar commented on code in PR #46:
URL: https://github.com/apache/incubator-pekko-persistence-cassandra/pull/46#discussion_r1190896708
##########
project/Dependencies.scala:
##########
@@ -49,6 +49,7 @@ object Dependencies {
"org.apache.pekko" %% "pekko-connectors-cassandra" % pekkoConnectorsVersion,
"org.apache.pekko" %% "pekko-persistence" % pekkoVersion,
"org.apache.pekko" %% "pekko-persistence-query" % pekkoVersion,
+ "org.apache.pekko" %% "pekko-stream" % pekkoVersion,
Review Comment:
Yes, but since the project relies heavily on streams it would make sense to me to keep the explicit dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-cassandra] mdedetrich commented on pull request #46: Apply compat changes from latest Pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #46:
URL: https://github.com/apache/incubator-pekko-persistence-cassandra/pull/46#issuecomment-1543789458
New version is `1079-c30f82ae-SNAPSHOT`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-cassandra] nvollmar merged pull request #46: Apply compat changes from latest Pekko
Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar merged PR #46:
URL: https://github.com/apache/incubator-pekko-persistence-cassandra/pull/46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org