You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/01/21 20:12:41 UTC
[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8211: epoll.h: Add u64 field like Linux
xiaoxiang781216 opened a new pull request, #8211:
URL: https://github.com/apache/nuttx/pull/8211
## Summary
https://man7.org/linux/man-pages/man2/epoll_wait.2.html
## Impact
New fields
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko merged pull request #8211: epoll.h: Add u64 field like Linux
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko merged PR #8211:
URL: https://github.com/apache/nuttx/pull/8211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8211: epoll.h: Add u64 field like Linux
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #8211:
URL: https://github.com/apache/nuttx/pull/8211#discussion_r1087620641
##########
include/sys/epoll.h:
##########
@@ -91,11 +94,14 @@ enum
#define EPOLL_CLOEXEC EPOLL_CLOEXEC
};
-typedef union poll_data
+typedef union epoll_data
{
FAR void *ptr;
int fd;
uint32_t u32;
+#ifdef CONFIG_HAVE_LONG_LONG
+ uint64_t u64;
+#endif
} epoll_data_t;
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8211: epoll.h: Add u64 field like Linux
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #8211:
URL: https://github.com/apache/nuttx/pull/8211#issuecomment-1403563880
let's merge this patch? @acassis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8211: epoll.h: Add u64 field like Linux
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #8211:
URL: https://github.com/apache/nuttx/pull/8211#discussion_r1087201829
##########
include/sys/epoll.h:
##########
@@ -91,11 +94,14 @@ enum
#define EPOLL_CLOEXEC EPOLL_CLOEXEC
};
-typedef union poll_data
+typedef union epoll_data
{
FAR void *ptr;
int fd;
uint32_t u32;
+#ifdef CONFIG_HAVE_LONG_LONG
+ uint64_t u64;
+#endif
} epoll_data_t;
Review Comment:
can we change to
```
union epoll_data
{
FAR void *ptr;
int fd;
uint32_t u32;
#ifdef CONFIG_HAVE_LONG_LONG
uint64_t u64;
#endif
};
typedef union epoll_data epoll_data_t;
```
?
I think that is what is used in most of the files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org